[PATCH 2/11] drivers/watchdog: Eliminate a NULL pointer dereference
authorJulia Lawall <julia@diku.dk>
Thu, 27 May 2010 12:32:24 +0000 (14:32 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 7 Jun 2010 15:55:03 +0000 (15:55 +0000)
commitcfca31ce789963c0dd6ca2e9cc13b90cc2802fbd
tree9e070bff1b5c69a126b9c5dfbd1b5dd11df2263e
parent386f40c86d6c8d5b717ef20620af1a750d0dacb4
[PATCH 2/11] drivers/watchdog: Eliminate a NULL pointer dereference

At the point of the call to dev_err, wm8350 is NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/wm8350_wdt.c