netfilter: don't xt_jumpstack_alloc twice in xt_register_table
authorXiaotian Feng <dfeng@redhat.com>
Mon, 31 May 2010 14:41:09 +0000 (16:41 +0200)
committerPatrick McHardy <kaber@trash.net>
Mon, 31 May 2010 14:41:09 +0000 (16:41 +0200)
commitc936e8bd1de2fa50c49e3df6fa5036bf07870b67
tree41cbd0cad5110ad5fea36564e762a0693184cc05
parent67a3e12b05e055c0415c556a315a3d3eb637e29e
netfilter: don't xt_jumpstack_alloc twice in xt_register_table

In xt_register_table, xt_jumpstack_alloc is called first, later
xt_replace_table is used. But in xt_replace_table, xt_jumpstack_alloc
will be used again. Then the memory allocated by previous xt_jumpstack_alloc
will be leaked. We can simply remove the previous xt_jumpstack_alloc because
there aren't any users of newinfo between xt_jumpstack_alloc and
xt_replace_table.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Cc: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jan Engelhardt <jengelh@medozas.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Acked-By: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/netfilter/x_tables.c