KVM: VMX: Remove redundant test in vmx_set_efer()
authorJulia Lawall <julia@diku.dk>
Sat, 6 Feb 2010 08:43:03 +0000 (09:43 +0100)
committerMarcelo Tosatti <mtosatti@redhat.com>
Mon, 1 Mar 2010 15:36:07 +0000 (12:36 -0300)
commitc45b4fd416f5497b6b38dd70acc0e5b01399e5c9
treebe641dac5be99156204405d5e8cb78765e015d61
parent16fbb5eecc4ab8d4eb4d2a683d7fd74ccacc890b
KVM: VMX: Remove redundant test in vmx_set_efer()

msr was tested above, so the second test is not needed.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@

if (x == NULL || ...) {
    ... when forall
    return ...; }
... when != goto l;
    when != x = e
    when != &x
*x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/vmx.c