[SCSI] libfc: call ddp setup for only FCP reads to avoid accessing junk fsp pointer
authorVasu Dev <vasu.dev@intel.com>
Tue, 16 Feb 2010 20:15:18 +0000 (12:15 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Wed, 17 Feb 2010 23:43:34 +0000 (17:43 -0600)
commitbe88d3b26897e3e942f2f36ad3d0ffbe002c0088
tree6c815aca8a78df980e9dafaa7cecf3a6ba5af33f
parent5fceef1f357e1b3485363e6e240369fc8cbee173
[SCSI] libfc: call ddp setup for only FCP reads to avoid accessing junk fsp pointer

Adds check to call fc_fcp_ddp_setup for only FCP read cmds to avoid
accessing junk fsp pointer at least in ESX since non FCP frame had
junk fsp value, though fsp is implicitly initialized to null
by __alloc_skb but with this patch no more relying on fsp
initialized to null value and hitting junk fsp ptr access.

Removes fsp pointer checking in fc_fcp_ddp_setup as this is not
needed any more since its only caller for FCP read will always
have a valid fsp.

Reported by: Frank Zhang <frank_1.zhang@intel.com>
Reported by: Rob Love <robert.w.love@intel.com>
Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/libfc/fc_exch.c
drivers/scsi/libfc/fc_fcp.c