git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b75c6db) | patch
net: sysfs: ethtool_ops can be NULL
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 26 Oct 2009 01:23:33 +0000 (01:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2009 10:59:46 +0000 (03:59 -0700)
commitac5e3af9996fb911d4fdff910a8ac3cb7fc63a94
treec6c56403289c8bff16884592dc76d276444e9f04tree | snapshot
parentb75c6dbb45a49289b90f885c7fb6d9ac39a21688commit | diff
net: sysfs: ethtool_ops can be NULL

commit d519e17e2d01a0ee9abe083019532061b4438065
(net: export device speed and duplex via sysfs)
made the wrong assumption that netdev->ethtool_ops was always set.

This makes possible to crash kernel and let rtnl in locked state.

modprobe dummy
ip link set dummy0 up
(udev runs and crash)

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c diff | blob | history
Full containers within linux kernel