nfsd: Fix sort_pacl in fs/nfsd/nf4acl.c to actually sort groups
authorFrank Filz <ffilzlnx@us.ibm.com>
Wed, 21 Oct 2009 23:45:02 +0000 (16:45 -0700)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 27 Oct 2009 23:34:44 +0000 (19:34 -0400)
commitaba24d71580180dfdf6a1a83a5858a1c048fd785
treefc96b617d4ec4b92965513cab2a1bdfc8298fec5
parentdc83d6e27fa80babe31c80aa8568f125f72edf57
nfsd: Fix sort_pacl in fs/nfsd/nf4acl.c to actually sort groups

We have been doing some extensive testing of Linux support for ACLs on
NFDS v4. We have noticed that the server rejects ACLs where the groups
are out of order, for example, the following ACL is rejected:

A::OWNER@:rwaxtTcCy
A::user101@domain:rwaxtcy
A::GROUP@:rwaxtcy
A:g:group102@domain:rwaxtcy
A:g:group101@domain:rwaxtcy
A::EVERYONE@:rwaxtcy

Examining the server code, I found that after converting an NFS v4 ACL
to POSIX, sort_pacl is called to sort the user ACEs and group ACEs.
Unfortunately, a minor bug causes the group sort to be skipped.

Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/nfsd/nfs4acl.c