nfs: Panic when commit fails
authorTerry Loftin <terry.loftin@hp.com>
Fri, 23 Oct 2009 01:36:01 +0000 (21:36 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 23 Oct 2009 18:16:30 +0000 (14:16 -0400)
commita8b40bc7e635831b61c43acc71a86d3a68b2dff0
tree8a91dcd2149f47d2a2b6f7b49d653dd168c908a8
parent964fe080d94db82a3268443e9b9ece4c60246414
nfs: Panic when commit fails

Actually pass the NFS_FILE_SYNC option to the server to avoid a
Panic in nfs_direct_write_complete() when a commit fails.

At the end of an nfs write, if the nfs commit fails, all the writes
will be rescheduled.  They are supposed to be rescheduled as NFS_FILE_SYNC
writes, but the rpc_task structure is not completely intialized and so
the option is not passed.  When the rescheduled writes complete, the
return indicates that they are NFS_UNSTABLE and we try to do another
commit.  This leads to a Panic because the commit data structure pointer
was set to null in the initial (failed) commit attempt.

Signed-off-by: Terry Loftin <terry.loftin@hp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/direct.c