HID: fix memory leak on error patch in debug code
authorJulia Lawall <julia@diku.dk>
Sat, 8 Aug 2009 00:26:10 +0000 (02:26 +0200)
committerJiri Kosina <jkosina@suse.cz>
Sat, 8 Aug 2009 00:26:10 +0000 (02:26 +0200)
commita809dda0369ae6157f7bcd3e704b857d43704cbd
tree075488e5c5d8d34e4b5405521095ba9b3947c20d
parent55dba52458a11126ff4445b5b94ebde03afcf47a
HID: fix memory leak on error patch in debug code

Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-debug.c