powerpc/pseries/dlpar: Eliminate use after free
authorJulia Lawall <julia@diku.dk>
Fri, 2 Apr 2010 02:47:13 +0000 (02:47 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 7 Apr 2010 08:00:41 +0000 (18:00 +1000)
commita7df5c5e52a545774c4db1f2adf09ede018ab139
treeb02fab55d085a9057a5a62bafe35ae69f1cc1bdd
parentab30f78c0afbb86584144925e25c7ca68ba9a91f
powerpc/pseries/dlpar: Eliminate use after free

dlpar_free_cc_nodes frees its argument, so dlpar_online_cpu should not be
called on the same value.  Skip over the call to dlpar_online_cpu by
jumping directly to out.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E,E2;
@@

dlpar_free_cc_nodes(E)
...
(
  E = E2
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/pseries/dlpar.c