netfilter: nfnetlink_log: fix silly refcount leak
authorAlexey Dobriyan <adobriyan@gmail.com>
Fri, 26 Feb 2010 16:48:40 +0000 (17:48 +0100)
committerPatrick McHardy <kaber@trash.net>
Fri, 26 Feb 2010 16:48:40 +0000 (17:48 +0100)
commita49c65037146bfb2fe300b8277b10b4479fea5fc
tree3007e26205ca186f3122948efbb402d316253966
parent51f0bc78680edccb6574ef56bd32f9e2939c8a5a
netfilter: nfnetlink_log: fix silly refcount leak

Quick fix for memory/module refcount leak.
Reference count of listener instance never reaches 0.

Start/stop of ulogd2 is enough to trigger this bug!

Now, refcounting there looks very fishy in particular this code:

  if (!try_module_get(THIS_MODULE)) {
...

and creation of listener instance with refcount 2,
so it may very well be ripped and redone.  :-)

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/netfilter/nfnetlink_log.c