xfrm: fix policy unreferencing on larval drop
authorTimo Teras <timo.teras@iki.fi>
Sun, 16 May 2010 06:49:26 +0000 (23:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 16 May 2010 06:49:26 +0000 (23:49 -0700)
commita1aa3483041bd3691c7f029272ccef4ce70bd957
tree10aae3a5100a85fad5ca81da37e4bf1b064d29bb
parenta14462f1bd4d3962994f518459102000438665aa
xfrm: fix policy unreferencing on larval drop

I mistakenly had the error path to use num_pols to decide how
many policies we need to drop (cruft from earlier patch set
version which did not handle socket policies right).

This is wrong since normally we do not keep explicit references
(instead we hold reference to the cache entry which holds references
to policies). drop_pols is set to num_pols if we are holding the
references, so use that. Otherwise we eventually BUG_ON inside
xfrm_policy_destroy due to premature policy deletion.

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_policy.c