Remove argument from open_softirq which is always NULL
authorCarlos R. Mafra <crmafra2@gmail.com>
Thu, 15 May 2008 14:15:37 +0000 (11:15 -0300)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 25 May 2008 05:43:15 +0000 (07:43 +0200)
commit962cf36c5bf6d2840b8d66ee9a606fae2f540bbd
tree263ead6b5224453e8c2a92f1ad9cd2091e003b68
parent75d3bce2fc0a80f435fe12f2c9ed2632c8ac29e4
Remove argument from open_softirq which is always NULL

As git-grep shows, open_softirq() is always called with the last argument
being NULL

block/blk-core.c:       open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL);
kernel/hrtimer.c:       open_softirq(HRTIMER_SOFTIRQ, run_hrtimer_softirq, NULL);
kernel/rcuclassic.c:    open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/rcupreempt.c:    open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/sched.c: open_softirq(SCHED_SOFTIRQ, run_rebalance_domains, NULL);
kernel/softirq.c:       open_softirq(TASKLET_SOFTIRQ, tasklet_action, NULL);
kernel/softirq.c:       open_softirq(HI_SOFTIRQ, tasklet_hi_action, NULL);
kernel/timer.c: open_softirq(TIMER_SOFTIRQ, run_timer_softirq, NULL);
net/core/dev.c: open_softirq(NET_TX_SOFTIRQ, net_tx_action, NULL);
net/core/dev.c: open_softirq(NET_RX_SOFTIRQ, net_rx_action, NULL);

This observation has already been made by Matthew Wilcox in June 2002
(http://www.cs.helsinki.fi/linux/linux-kernel/2002-25/0687.html)

"I notice that none of the current softirq routines use the data element
passed to them."

and the situation hasn't changed since them. So it appears we can safely
remove that extra argument to save 128 (54) bytes of kernel data (text).

Signed-off-by: Carlos R. Mafra <crmafra@ift.unesp.br>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
block/blk-core.c
include/linux/interrupt.h
kernel/hrtimer.c
kernel/rcuclassic.c
kernel/rcupreempt.c
kernel/sched.c
kernel/softirq.c
kernel/timer.c
net/core/dev.c