NFSv41: Fix a potential state leakage when restarting nfs4_close_prepare
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 8 Dec 2009 13:33:16 +0000 (08:33 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 8 Dec 2009 13:33:16 +0000 (08:33 -0500)
commit88069f77e1ac580a495762ce7a631c251c52cb90
treee30011cdb39fa167370b4d35bbc9b3cc04a4bc27
parent74e7bb73a3e0d15a7db10b0f2b2efdeeef36609e
NFSv41: Fix a potential state leakage when restarting nfs4_close_prepare

Currently, if the call to nfs4_setup_sequence() in nfs4_close_prepare
fails, any later retries will fail to launch an RPC call, due to the fact
that the &state->flags will have been cleared.
Ditto if nfs4_close_done() triggers a call to the NFSv4.1 version of
nfs_restart_rpc().

We therefore move the actual clearing of the state->flags to
nfs4_close_done(), when we know that the RPC call was successful.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4proc.c