xfs: simplify inode teardown
authorChristoph Hellwig <hch@infradead.org>
Tue, 29 Sep 2009 13:48:56 +0000 (13:48 +0000)
committerAlex Elder <aelder@sgi.com>
Fri, 11 Dec 2009 21:11:19 +0000 (15:11 -0600)
commit848ce8f731aed0a2d4ab5884a4f6664af73d2dd0
treecb8bdd8d2ce23f586e4bc0351dc934ae37a6db4e
parent22763c5cf3690a681551162c15d34d935308c8d7
xfs: simplify inode teardown

Currently the reclaim code for the case where we don't reclaim the
final reclaim is overly complicated.  We know that the inode is clean
but instead of just directly reclaiming the clean inode we go through
the whole process of marking the inode reclaimable just to directly
reclaim it from the calling context.  Besides being overly complicated
this introduces a race where iget could recycle an inode between
marked reclaimable and actually being reclaimed leading to panics.

This patch gets rid of the existing reclaim path, and replaces it with
a simple call to xfs_ireclaim if the inode was clean.  While we're at
it we also use the slightly more lax xfs_inode_clean check we'd use
later to determine if we need to flush the inode here.

Finally get rid of xfs_reclaim function and place the remaining small
bits of reclaim code directly into xfs_fs_destroy_inode.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Patrick Schreurs <patrick@news-service.com>
Reported-by: Tommy van Leeuwen <tommy@news-service.com>
Tested-by: Patrick Schreurs <patrick@news-service.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/linux-2.6/xfs_super.c
fs/xfs/linux-2.6/xfs_sync.c
fs/xfs/linux-2.6/xfs_sync.h
fs/xfs/xfs_vnodeops.c
fs/xfs/xfs_vnodeops.h