CacheFiles: Fix error handling in cachefiles_determine_cache_security()
authorDavid Howells <dhowells@redhat.com>
Wed, 12 May 2010 14:34:03 +0000 (15:34 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 13 May 2010 01:23:58 +0000 (18:23 -0700)
commit7ac512aa8237c43331ffaf77a4fd8b8d684819ba
tree0fe199f0364c5b54012691c9e4ff4a11767d1797
parent91af70814105f4c05e6e11b51c3269907b71794b
CacheFiles: Fix error handling in cachefiles_determine_cache_security()

cachefiles_determine_cache_security() is expected to return with a
security override in place.  However, if set_create_files_as() fails, we
fail to do this.  In this case, we should just reinstate the security
override that was set by the caller.

Furthermore, if set_create_files_as() fails, we should dispose of the
new credentials we were in the process of creating.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/cachefiles/security.c