[XFS] Remove unnecessary assertion
authorLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Fri, 5 Dec 2008 03:15:49 +0000 (14:15 +1100)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Fri, 5 Dec 2008 03:15:49 +0000 (14:15 +1100)
commit797eaed40e1df4a3b9ece6894a71ce2b568bca38
tree930f84ddfa6cf8cb7e4ff81122cafd877489c02f
parenta5b429d41fede3a90deb532f5c2318393ed3a17b
[XFS] Remove unnecessary assertion

Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but
not XFS_IRECLAIMABLE|XFS_IRECLAIM.  This is because xfs_iget_cache_hit()
first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag()
while only holding the pag_ici_lock in read mode so we can race with
xfs_reclaim_inodes_ag().  Looks like xfs_reclaim_inodes_ag() will do the
right thing anyway so just remove the assert.

Thanks to Christoph for pointing out where the problem was.

Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
fs/xfs/linux-2.6/xfs_sync.c