git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e6114fa) | patch
tty: Fix unbalanced BKL handling in error path
authorAlan Cox <alan@linux.intel.com>
Tue, 4 May 2010 19:42:36 +0000 (20:42 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 13 May 2010 19:10:56 +0000 (12:10 -0700)
commit77945febbe60a69e9dcab7f49d33a1aa1e436973
tree1475c6c8215e831904e78a08d1947ffb5a1516cetree | snapshot
parente6114fa1d1d6a588766f28081b971047dd3e5defcommit | diff
tty: Fix unbalanced BKL handling in error path

Arnd noted:

After the "retry_open:" label, we first get the tty_mutex
and then the BKL. However a the end of tty_open, we jump
back to retry_open with the BKL still held. If we run into
this case, the tty_open function will be left with the BKL
still held.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/tty_io.c diff | blob | history
Full containers within linux kernel