kmemtrace, fs: uninline simple_transaction_set()
authorIngo Molnar <mingo@elte.hu>
Wed, 25 Mar 2009 15:48:35 +0000 (16:48 +0100)
committerIngo Molnar <mingo@elte.hu>
Fri, 3 Apr 2009 10:09:09 +0000 (12:09 +0200)
commit76791ab2d5e00c1eef728a8df4347ba133760fb8
tree8065964f857f0627b4dd3ea041dfd4c92df70bc9
parent3d544f411f2971eb82f5c52322251eb04494542a
kmemtrace, fs: uninline simple_transaction_set()

Impact: cleanup

We want to remove percpu.h from rcupdate.h (for upcoming kmemtrace
changes), but this is not possible currently without breaking the
build because fs.h has an implicit include file depedency: it
uses PAGE_SIZE but does not include asm/page.h which defines it.

This problem gets masked in practice because most fs.h using sites
use rcupreempt.h (and other headers) which includes percpu.h which
brings in asm/page.h indirectly.

We cannot add asm/page.h to asm/fs.h because page.h is not an
exported header.

Move simple_transaction_set() to the other simple-transaction
file helpers in fs/libfs.c.

This removes the include file hell and also reduces
kernel size a bit.

Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: paulmck@linux.vnet.ibm.com
LKML-Reference: <1237898630.25315.83.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
fs/libfs.c
include/linux/fs.h