tracing: Fix missing function_graph events when we splice_read from trace_pipe
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 28 Jul 2009 12:17:22 +0000 (20:17 +0800)
committerFrederic Weisbecker <fweisbec@gmail.com>
Tue, 28 Jul 2009 21:17:23 +0000 (23:17 +0200)
commit74e7ff8c50b6b022e6ffaa736b16a4dc161d3eaf
tree5bbe7b9f239f1e7b0a688b521f5dca8b9ea99ef4
parent38ceb592fcac9110c6b3c87ea0a27bff68c43486
tracing: Fix missing function_graph events when we splice_read from trace_pipe

About a half events are missing when we splice_read
from trace_pipe. They are unexpectedly consumed because we ignore
the TRACE_TYPE_NO_CONSUME return value used by the function graph
tracer when it needs to consume the events by itself to walk on
the ring buffer.

The same problem appears with ftrace_dump()

Example of an output before this patch:

1)               |      ktime_get_real() {
1)   2.846 us    |          read_hpet();
1)   4.558 us    |        }
1)   6.195 us    |      }

After this patch:

0)               |      ktime_get_real() {
0)               |        getnstimeofday() {
0)   1.960 us    |          read_hpet();
0)   3.597 us    |        }
0)   5.196 us    |      }

The fix also applies on 2.6.30

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: stable@kernel.org
LKML-Reference: <4A6EEC52.90704@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
kernel/trace/trace.c