SLUB: Fix __GFP_ZERO unlikely() annotation
authorPekka Enberg <penberg@cs.helsinki.fi>
Wed, 25 Nov 2009 18:14:48 +0000 (20:14 +0200)
committerPekka Enberg <penberg@cs.helsinki.fi>
Sun, 29 Nov 2009 07:01:59 +0000 (09:01 +0200)
commit74e2134ff892ee4ea4fbd52637060b71e540faf1
treea0747c885ca2bc04745a77ef4a902d121acbe44f
parentb419148e567728f6af0c3b01965c1cc141e3e13a
SLUB: Fix __GFP_ZERO unlikely() annotation

The unlikely() annotation in slab_alloc() covers too much of the expression.
It's actually very likely that the object is not NULL so use unlikely() only
for the __GFP_ZERO expression like SLAB does.

The patch reduces kernel text by 29 bytes on x86-64:

   text    data     bss     dec     hex filename
  24185    8560     176   32921    8099 mm/slub.o.orig
  24156    8560     176   32892    807c mm/slub.o

Acked-by: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
mm/slub.c