git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fe86175) | patch
sx.c: fix missed unlock_kernel() on error path in sx_fw_ioctl()
authorDan Carpenter <error27@gmail.com>
Wed, 4 Feb 2009 23:12:20 +0000 (15:12 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Feb 2009 20:56:48 +0000 (12:56 -0800)
commit736d54533aedbcbde8cfb2f9ccd542595db4d78d
tree83fbdc15a5ad032e47c9d237617a67866303767btree | snapshot
parentfe86175bce50bc3d65ff09c287fed955c4da1eb3commit | diff
sx.c: fix missed unlock_kernel() on error path in sx_fw_ioctl()

If we return directly with -EPERM then lock_kernel() is still held.

This was found with a code checker (http://repo.or.cz/w/smatch.git/).

[akpm@linux-foundation.org: fix another such path - missed func_exit()]
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: <R.E.Wolff@BitWizard.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/sx.c diff | blob | history
Full containers within linux kernel