sky2: no recycling
authorStephen Hemminger <shemminger@vyatta.com>
Tue, 18 Aug 2009 15:17:10 +0000 (15:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Aug 2009 03:26:53 +0000 (20:26 -0700)
commit724b694225e711f95e6265afdbc304c9e7eb3721
tree9fbad7f1126dee297108e943082ae565b7a72bac
parent6b84dacadbdc3dab6a5b313d20d5a93b0d998641
sky2: no recycling

Recycling turns out to be a bad idea!  For most use cases, the
packet can not be reused: TCP packets are cloned. Even for the ideal
case of forwarding, it hurts performance because of CPU ping/pong.
On a multi-core system forwarding of 64 byte packets is worse
much worse: recycling = 24% forwarded vs no recycling = 42% forwarded

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sky2.c
drivers/net/sky2.h