NFSv4: Fix an infinite looping problem with the nfs4_state_manager
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 24 Aug 2009 23:21:29 +0000 (19:21 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 24 Aug 2009 23:28:42 +0000 (16:28 -0700)
commit7111dc73923e9737b38a3ef5b5f236109000ff28
treea21d3fbdf710b8a5ecfede32b822368fea2cad40
parent2584e7986f235572d4b03bbe52fd1e85c1679b8e
NFSv4: Fix an infinite looping problem with the nfs4_state_manager

Commit 76db6d9500caeaa774a3e32a997eba30bbdc176b (nfs41: add session setup
to the state manager) introduces an infinite loop possibility in the NFSv4
state manager. By first checking nfs4_has_session() before clearing the
NFS4CLNT_SESSION_SETUP flag, it allows for a situation where someone sets
that flag, but it never gets cleared, and so the state manager loops.

In fact commit c3fad1b1aaf850bf692642642ace7cd0d64af0a3 (nfs41: add session
reset to state manager) causes this to happen every time we get a network
partition error.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Tested-by: Daniel J Blueman <daniel.blueman@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfs/nfs4state.c