atmel_spi: fix dma addr calculation for len > BUFFER_SIZE
authorBen Nizette <bn@niasdigital.com>
Tue, 15 Dec 2009 06:20:20 +0000 (22:20 -0800)
committerGrant Likely <grant.likely@secretlab.ca>
Thu, 17 Dec 2009 15:57:07 +0000 (08:57 -0700)
commit6aed4ee9b4610cd1e0315c90855b32e59ee81a15
tree5866dec5080de784cb01ce3a6426a8d4d111636e
parentbec0806cfec6ded1a7e097bb95279e521a796129
atmel_spi: fix dma addr calculation for len > BUFFER_SIZE

If len > BUFFER_LEN and !xfer->rx_buf we end up calculating the tx buffer
address as

*tx_dma = xfer->tx_dma + xfer->len - BUFFER_SIZE;

which is constant; i.e.  we just send the last BUFFER_SIZE data over again
until we've reached the right number of bytes.

This patch gets around this by using the /requested/ length when
calculating addresses.

Note there's no way len != *plen when we calculate the rx buffer address
but conceptually we should be using *plen and I don't want someone to come
through later, see the calculations for rx and tx are different and "clean
up" back to what we had.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/atmel_spi.c