sched: _cpu_down(): Don't play with current->cpus_allowed
authorOleg Nesterov <oleg@redhat.com>
Mon, 15 Mar 2010 09:10:23 +0000 (10:10 +0100)
committerIngo Molnar <mingo@elte.hu>
Fri, 2 Apr 2010 18:12:03 +0000 (20:12 +0200)
commit6a1bdc1b577ebcb65f6603c57f8347309bc4ab13
tree516130eedf782dd14505bd111e06bcfad9923b07
parent30da688ef6b76e01969b00608202fff1eed2accc
sched: _cpu_down(): Don't play with current->cpus_allowed

_cpu_down() changes the current task's affinity and then recovers it at
the end. The problems are well known: we can't restore old_allowed if it
was bound to the now-dead-cpu, and we can race with the userspace which
can change cpu-affinity during unplug.

_cpu_down() should not play with current->cpus_allowed at all. Instead,
take_cpu_down() can migrate the caller of _cpu_down() after __cpu_disable()
removes the dying cpu from cpu_online_mask.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100315091023.GA9148@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/sched.h
kernel/cpu.c
kernel/sched.c