hrtimers: allow the hot-unplugging of all cpus
authorSebastien Dugue <sebastien.dugue@bull.net>
Mon, 1 Dec 2008 13:09:07 +0000 (14:09 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 30 Dec 2008 06:37:19 +0000 (07:37 +0100)
commit5762ba1873b0bb9faa631aaa02f533c2b9837f82
tree3ea61b03a12ec16620f8527c4c83cb90d80cf6cc
parent0ce74d9296c971b2355c26984ad0bc538e34dd6c
hrtimers: allow the hot-unplugging of all cpus

Impact: fix CPU hotplug hang on Power6 testbox

On architectures that support offlining all cpus (at least powerpc/pseries),
hot-unpluging the tick_do_timer_cpu can result in a system hang.

This comes from the fact that if the cpu going down happens to be the
cpu doing the tick, then as the tick_do_timer_cpu handover happens after the
cpu is dead (via the CPU_DEAD notification), we're left without ticks,
jiffies are frozen and any task relying on timers (msleep, ...) is stuck.
That's particularly the case for the cpu looping in __cpu_die() waiting
for the dying cpu to be dead.

This patch addresses this by having the tick_do_timer_cpu handover happen
earlier during the CPU_DYING notification. For this, a new clockevent
notification type is introduced (CLOCK_EVT_NOTIFY_CPU_DYING) which is triggered
in hrtimer_cpu_notify().

Signed-off-by: Sebastien Dugue <sebastien.dugue@bull.net>
Cc: <stable@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/clockchips.h
kernel/hrtimer.c
kernel/time/tick-common.c