git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8f55f3c) | patch
nfsd: Fix unnecessary deny bits in NFSv4 ACL
authorFrank Filz <ffilzlnx@us.ibm.com>
Fri, 14 Aug 2009 22:02:30 +0000 (15:02 -0700)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 25 Aug 2009 00:01:22 +0000 (20:01 -0400)
commit55bb55dca0cecac2fb7b8c743db41361c011c8a8
tree148b3ccee78940f424c3ecc1c5b2e9f46527a200tree | snapshot
parent8f55f3c0a013c42fb733997da54a3326c74601e8commit | diff
nfsd: Fix unnecessary deny bits in NFSv4 ACL

The group deny entries end up denying tcy even though tcy was just
allowed by the allow entry. This appears to be due to:
ace->access_mask = mask_from_posix(deny, flags);
instead of:
ace->access_mask = deny_mask_from_posix(deny, flags);

Denying a previously allowed bit has no effect, so this shouldn't affect
behavior, but it's ugly.

Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/nfsd/nfs4acl.c diff | blob | history
Full containers within linux kernel