netfilter: xt_rateest: fix comparison with self
authorPatrick McHardy <kaber@trash.net>
Mon, 22 Jun 2009 12:17:12 +0000 (14:17 +0200)
committerPatrick McHardy <kaber@trash.net>
Mon, 22 Jun 2009 12:17:12 +0000 (14:17 +0200)
commit4d900f9df5f0569c2dc536701e2c11b6d50ebebf
treee1ea624237ce9fab843080263ec51c5cadbe5c22
parent6d62182fea6cc6bbc8d82a691ad0608d68a54aeb
netfilter: xt_rateest: fix comparison with self

As noticed by Török Edwin <edwintorok@gmail.com>:

Compiling the kernel with clang has shown this warning:

net/netfilter/xt_rateest.c:69:16: warning: self-comparison always results in a
constant value
                        ret &= pps2 == pps2;
                                    ^
Looking at the code:
if (info->flags & XT_RATEEST_MATCH_BPS)
            ret &= bps1 == bps2;
        if (info->flags & XT_RATEEST_MATCH_PPS)
            ret &= pps2 == pps2;

Judging from the MATCH_BPS case it seems to be a typo, with the intention of
comparing pps1 with pps2.

http://bugzilla.kernel.org/show_bug.cgi?id=13535

Signed-off-by: Patrick McHardy <kaber@trash.net>
net/netfilter/xt_rateest.c