spi: move bitbang txrx utility functions to private header
authorhartleys <hartleys@visionengravers.com>
Thu, 6 May 2010 20:51:04 +0000 (20:51 +0000)
committerGrant Likely <grant.likely@secretlab.ca>
Tue, 25 May 2010 06:23:17 +0000 (00:23 -0600)
commit41c4221ca6b9db8ea63d2c2323c0e7a8865eba6e
tree31e12f709964805f9d73cf834297950b9ad09000
parent6e27388f1bd60b55e0b1a83d14233e6c7ad33700
spi: move bitbang txrx utility functions to private header

A number of files in drivers/spi fail checkincludes.pl due to the double
include of <linux/spi/spi_bitbang.h>.

The first include is needed to get the struct spi_bitbang definition and
the spi_bitbang_* function prototypes.

The second include happens after defining EXPAND_BITBANG_TXRX to get the
inlined bitbang_txrx_* utility functions.

The <linux/spi/spi_bitbang.h> header is also included by a number of other
spi drivers, as well as some arch/ code, in order to use struct spi_bitbang
and the associated functions.

To fix the double include, and remove any potential confusion about it, move
the inlined bitbang_txrx_* functions to a new private header in drivers/spi
and also remove the need to define EXPAND_BITBANG_TXRX.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/spi_bitbang_txrx.h [new file with mode: 0644]
drivers/spi/spi_butterfly.c
drivers/spi/spi_gpio.c
drivers/spi/spi_lm70llp.c
drivers/spi/spi_s3c24xx_gpio.c
drivers/spi/spi_sh_sci.c
include/linux/spi/spi_bitbang.h