KVM: Add locking to virtual i8259 interrupt controller
authorAvi Kivity <avi@qumranet.com>
Sun, 21 Dec 2008 20:48:32 +0000 (22:48 +0200)
committerAvi Kivity <avi@redhat.com>
Wed, 31 Dec 2008 14:55:48 +0000 (16:55 +0200)
commit3f353858c98dbe0240dac558a89870f4600f81bb
tree95cdddb90777c332f747dfff041e1caf1fe78673
parent25e2343246fe135fce672f41abe61e9d2c38caac
KVM: Add locking to virtual i8259 interrupt controller

While most accesses to the i8259 are with the kvm mutex taken, the call
to kvm_pic_read_irq() is not.  We can't easily take the kvm mutex there
since the function is called with interrupts disabled.

Fix by adding a spinlock to the virtual interrupt controller.  Since we
can't send an IPI under the spinlock (we also take the same spinlock in
an irq disabled context), we defer the IPI until the spinlock is released.
Similarly, we defer irq ack notifications until after spinlock release to
avoid lock recursion.

Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/i8259.c
arch/x86/kvm/irq.h