firewire: core: fix retries calculation in iso manage_channel()
authorClemens Ladisch <clemens@ladisch.de>
Mon, 12 Apr 2010 08:35:05 +0000 (10:35 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Mon, 19 Apr 2010 17:58:32 +0000 (19:58 +0200)
commit3a1f0a0e3d871e3d3e08a1429009992151becda8
tree79bb6e3cb82e58310442c986d46077ad8ff2dddc
parenta2612cb16d4d8447793609cbdd2a2f4f156c0020
firewire: core: fix retries calculation in iso manage_channel()

If there is a permanent error condition when communicating with the IRM,
after the sixth error, the retry variable will be decremented to -1.
If, in this case, the bits in channels_mask are not yet exhausted, the
next channel is retried 2^32 times.

To fix this, check that retry is never decremented beyond zero.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/core-iso.c