perf: Fix inconsistency between IP and callchain sampling
authorAnton Blanchard <anton@samba.org>
Mon, 18 Jan 2010 05:47:07 +0000 (16:47 +1100)
committerFrederic Weisbecker <fweisbec@gmail.com>
Thu, 28 Jan 2010 13:31:20 +0000 (14:31 +0100)
commit339ce1a4dc2ca26444c4f65c31b71a5056f3bb0b
tree84b0f9eeb823d788a79d6d601a01c0433d956132
parent408f0d18ba6b9bb447f807f621b2c9663c5cf638
perf: Fix inconsistency between IP and callchain sampling

When running perf across all cpus with backtracing (-a -g), sometimes we
get samples without associated backtraces:

    23.44%         init  [kernel]                     [k] restore
    11.46%         init                       eeba0c  [k] 0x00000000eeba0c
     6.77%      swapper  [kernel]                     [k] .perf_ctx_adjust_freq
     5.73%         init  [kernel]                     [k] .__trace_hcall_entry
     4.69%         perf  libc-2.9.so                  [.] 0x0000000006bb8c
                       |
                       |--11.11%-- 0xfffa941bbbc

It turns out the backtrace code has a check for the idle task and the IP
sampling does not. This creates problems when profiling an interrupt
heavy workload (in my case 10Gbit ethernet) since we get no backtraces
for interrupts received while idle (ie most of the workload).

Right now x86 and sh check that current is not NULL, which should never
happen so remove that too.

Idle task's exclusion must be performed from the core code, on top
of perf_event_attr:exclude_idle.

Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mundt <lethal@linux-sh.org>
LKML-Reference: <20100118054707.GT12666@kryten>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
arch/powerpc/kernel/perf_callchain.c
arch/sh/kernel/perf_callchain.c
arch/x86/kernel/cpu/perf_event.c