asus-acpi: Remove redundant NULL checks
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Thu, 3 Dec 2009 07:44:47 +0000 (07:44 +0000)
committerLen Brown <len.brown@intel.com>
Wed, 9 Dec 2009 20:54:30 +0000 (15:54 -0500)
commit2d5db0be4ce36b265f9ddd8debab40acd8580403
tree1d6f838397666ff07835279d93dd9594b90ca374
parent1df8d8d4efb7bce0e44d2aa91c4c0fa7ffe613c0
asus-acpi: Remove redundant NULL checks

The acpi device callbacks add, start, remove, suspend and resume can
never be called with a NULL acpi_device. Each callsite in acpi/scan.c
has to dereference the device in order to get the ops structure, e.g.

    struct acpi_device *acpi_dev = to_acpi_device(dev);
    struct acpi_driver *acpi_drv = acpi_dev->driver;

    if (acpi_drv && acpi_drv->ops.suspend)
        return acpi_drv->ops.suspend(acpi_dev, state);

Remove all checks for acpi_dev == NULL within these callbacks.

Also remove the checks for acpi_driver_data(acpi_dev) == NULL. None of
these checks could fail unless the driver does something strange
(which none of them do), the acpi core did something terribly wrong,
or we have a memory corruption issue. If this does happen then it's
best to dereference the pointer and crash noisily.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/asus_acpi.c