eCryptfs: NULL crypt_stat dereference during lookup
authorTyler Hicks <tyhicks@linux.vnet.ibm.com>
Fri, 20 Mar 2009 07:23:57 +0000 (02:23 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 22 Mar 2009 18:20:43 +0000 (11:20 -0700)
commit2aac0cf88681bfa092f731553bc7fbd23516be73
treeb723cbe9c67b0cafa9081690d03b4ecec038d9f6
parent8faece5f906725c10e7a1f6caf84452abadbdc7b
eCryptfs: NULL crypt_stat dereference during lookup

If ecryptfs_encrypted_view or ecryptfs_xattr_metadata were being
specified as mount options, a NULL pointer dereference of crypt_stat
was possible during lookup.

This patch moves the crypt_stat assignment into
ecryptfs_lookup_and_interpose_lower(), ensuring that crypt_stat
will not be NULL before we attempt to dereference it.

Thanks to Dan Carpenter and his static analysis tool, smatch, for
finding this bug.

Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Acked-by: Dustin Kirkland <kirkland@canonical.com>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ecryptfs/crypto.c
fs/ecryptfs/ecryptfs_kernel.h
fs/ecryptfs/inode.c