libata-sff: update bmdma host bus error handling
authorTejun Heo <tj@kernel.org>
Mon, 10 May 2010 19:41:28 +0000 (21:41 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Sat, 15 May 2010 02:38:44 +0000 (22:38 -0400)
commit2a7adff09ac3dd3d1facaf92b4a8cc1b92d370b6
treea2c41f4ee10893795dbd04215798a2469bb994ae
parent1b959c412bbf38ce0fa658183f72027ca8331ee3
libata-sff: update bmdma host bus error handling

* Clearing IRQ from ata_sff_error_handler() is necessary only when the
  port is gonna be thawed before performing EH actions and some
  controllers don't like being accessed after certain failure modes
  until they're reset.  Clear IRQ iff the port is being thawed.

* When the controller succesfully indicated bus error, the point of
  thawing doesn't matter.  Move thawing inside bmdma part of EH.  This
  is a bit ugly but will ease code reorganization later.

* Remove the unneeded ata_sff_sync().

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-sff.c