drivers/gpio/timbgpio.c: add missing unlock
authorJulia Lawall <julia@diku.dk>
Tue, 6 Apr 2010 21:34:48 +0000 (14:34 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 7 Apr 2010 15:38:02 +0000 (08:38 -0700)
commit2a481800caf78f4750cc673c8baed12b5d703ff6
tree7ddbde66351fdf26c262fe8127a98704284e9456
parentc70c036f04b7b74282477d6a51bbcc8bb8897e03
drivers/gpio/timbgpio.c: add missing unlock

In an error handling case the lock is not unlocked.  The return is
converted to a goto, to share the unlock at the end of the function.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: <richard.rojfors@pelagicore.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpio/timbgpio.c