saner FASYNC handling on file close
authorAl Viro <viro@ZenIV.linux.org.uk>
Fri, 31 Oct 2008 23:28:30 +0000 (23:28 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 1 Nov 2008 16:49:46 +0000 (09:49 -0700)
commit233e70f4228e78eb2f80dc6650f65d3ae3dbf17c
tree4e18fbe1851e6d2161b7f18265cb21f8a61e3ce7
parent3318a386e4ca68c76e0294363d29bdc46fcad670
saner FASYNC handling on file close

As it is, all instances of ->release() for files that have ->fasync()
need to remember to evict file from fasync lists; forgetting that
creates a hole and we actually have a bunch that *does* forget.

So let's keep our lives simple - let __fput() check FASYNC in
file->f_flags and call ->fasync() there if it's been set.  And lose that
crap in ->release() instances - leaving it there is still valid, but we
don't have to bother anymore.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
36 files changed:
arch/ia64/kernel/perfmon.c
drivers/char/hpet.c
drivers/char/ipmi/ipmi_devintf.c
drivers/char/ipmi/ipmi_watchdog.c
drivers/char/random.c
drivers/char/rtc.c
drivers/char/sonypi.c
drivers/gpu/drm/drm_fops.c
drivers/hid/usbhid/hiddev.c
drivers/ieee1394/dv1394.c
drivers/infiniband/core/uverbs_main.c
drivers/input/evdev.c
drivers/input/joydev.c
drivers/input/misc/hp_sdc_rtc.c
drivers/input/mousedev.c
drivers/input/serio/serio_raw.c
drivers/message/fusion/mptctl.c
drivers/message/i2o/i2o_config.c
drivers/misc/sony-laptop.c
drivers/net/tun.c
drivers/rtc/rtc-dev.c
drivers/scsi/megaraid/megaraid_sas.c
drivers/scsi/sg.c
drivers/staging/me4000/me4000.c
drivers/telephony/ixj.c
drivers/uio/uio.c
drivers/usb/gadget/inode.c
fs/file_table.c
fs/fuse/dev.c
fs/inotify_user.c
fs/pipe.c
net/socket.c
sound/core/control.c
sound/core/init.c
sound/core/pcm_native.c
sound/core/timer.c