Revert "module: drop the lock while waiting for module to complete initialization."
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 25 May 2010 23:48:30 +0000 (16:48 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 25 May 2010 23:48:30 +0000 (16:48 -0700)
commit218ce7351413b8287a80fab1d7b94906a5559f01
tree36ba694491fa39fbde719b889a89cadbedd1f357
parentec96e2fe954c23a54bfdf2673437a39e193a1822
Revert "module: drop the lock while waiting for module to complete initialization."

This reverts commit 480b02df3aa9f07d1c7df0cd8be7a5ca73893455, since
Rafael reports that it causes occasional kernel paging request faults in
load_module().

Dropping the module lock and re-taking it deep in the call-chain is
definitely not the right thing to do.  That just turns the mutex from a
lock into a "random non-locking data structure" that doesn't actually
protect what it's supposed to protect.

Requested-and-tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Brandon Philips <brandon@ifup.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/module.c