Bluetooth: Don't use hci_acl_connect_cancel() for incoming connections
authorMarcel Holtmann <marcel@holtmann.org>
Sat, 9 May 2009 19:04:08 +0000 (12:04 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Sun, 10 May 2009 01:09:45 +0000 (18:09 -0700)
commit1b0336bb36f88976f1210a65b62f6a3e9578ee7b
treebcf2a8413090c43ab6513b55e145bddf8fe87da6
parent384943ec1bb462e410390ad8f108ff1474cd882d
Bluetooth: Don't use hci_acl_connect_cancel() for incoming connections

The connection setup phase takes around 2 seconds or longer and in
that time it is possible that the need for an ACL connection is no
longer present. If that happens then, the connection attempt will
be canceled.

This only applies to outgoing connections, but currently it can also
be triggered by incoming connection. Don't call hci_acl_connect_cancel()
on incoming connection since these have to be either accepted or rejected
in this state. Once they are successfully connected they need to be
fully disconnected anyway.

Also remove the wrong hci_acl_disconn() call for SCO and eSCO links
since at this stage they can't be disconnected either, because the
connection handle is still unknown.

Based on a report by Johan Hedberg <johan.hedberg@nokia.com>

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Tested-by: Johan Hedberg <johan.hedberg@nokia.com>
net/bluetooth/hci_conn.c