tcp: missing check ACK flag of received segment in FIN-WAIT-2 state
authorWei Yongjun <yjwei@cn.fujitsu.com>
Wed, 24 Jun 2009 22:29:31 +0000 (22:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jun 2009 03:03:15 +0000 (20:03 -0700)
commit1ac530b3553e0b4dc1e18a32bed57cfa84cd57cb
treecc0198945aeee7b60ea06c1699fc72268efc26f7
parentd8146bb23ea045fb75c56b4e3b53f0964eed4076
tcp: missing check ACK flag of received segment in FIN-WAIT-2 state

RFC0793 defined that in FIN-WAIT-2 state if the ACK bit is off drop
the segment and return[Page 72]. But this check is missing in function
tcp_timewait_state_process(). This cause the segment with FIN flag but
no ACK has two diffent action:

Case 1:
    Node A                      Node B
              <-------------    FIN,ACK
                                (enter FIN-WAIT-1)
    ACK       ------------->
                                (enter FIN-WAIT-2)
    FIN       ------------->    discard
                                (move sk to tw list)

Case 2:
    Node A                      Node B
              <-------------    FIN,ACK
                                (enter FIN-WAIT-1)
    ACK       ------------->
                                (enter FIN-WAIT-2)
                                (move sk to tw list)
    FIN       ------------->

              <-------------    ACK

This patch fixed the problem.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_minisocks.c