git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 10662aa) | patch
netfilter: ipt_MASQUERADE: remove redundant rwlock
authorFlorian Westphal <fw@strlen.de>
Fri, 5 Jun 2009 11:26:21 +0000 (13:26 +0200)
committerPatrick McHardy <kaber@trash.net>
Fri, 5 Jun 2009 11:26:21 +0000 (13:26 +0200)
commit17f2f52be0edb6d1ff5a3675f2bc545aea2dbf76
tree50c1e9cb16c43c23525eccded67615f009bd691etree | snapshot
parent10662aa3083f869c645cc2abf5d66849001e2f5dcommit | diff
netfilter: ipt_MASQUERADE: remove redundant rwlock

The lock "protects" an assignment and a comparision of an integer.
When the caller of device_cmp() evaluates the result, nat->masq_index
may already have been changed (regardless if the lock is there or not).

So, the lock either has to be held during nf_ct_iterate_cleanup(),
or can be removed.

This does the latter.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/ipv4/netfilter/ipt_MASQUERADE.c diff | blob | history
Full containers within linux kernel