wl1271: fix the inetdev notifier callback return values
authorLuciano Coelho <luciano.coelho@nokia.com>
Mon, 23 Nov 2009 21:22:15 +0000 (23:22 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Sat, 28 Nov 2009 20:04:29 +0000 (15:04 -0500)
commit17d7265c7582af77357bd31884cef26f9f802313
tree8403c70ab2921f4aed1b1a5fa0adba6d964ef85f
parent03442a33174b1d9f6f8eb8c3c2e8a9cf4b75fffe
wl1271: fix the inetdev notifier callback return values

The wl1271_dev_notify() was returning 0 or -ENODEV, when it should return
NOTIFY_* instead.  Now we use NOTIFY_DONE when we didn't handle the event or
NOTIFY_OK when we have handled it.

For inetdev notifications, it doesn't matter whether we use NOTIFY_DONE or
NOTIFY_OK, because it ignores the return value of the call to
blocking_notifier_call_chain().  But the notify.h header says that
NOTIFY_DONE is "Don't care" and NOTIFY_OK is "Suits me", so that seems to be
the right way to do it.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Reviewed-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1271_main.c