x86: signal: check sas_ss_size instead of sas_ss_flags()
authorHiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Thu, 26 Mar 2009 17:03:08 +0000 (10:03 -0700)
committerIngo Molnar <mingo@elte.hu>
Wed, 1 Apr 2009 15:13:17 +0000 (17:13 +0200)
commit0f8f308925ebe0480bd9831d32963ee0b885e24b
tree3a4bef09e978eb314b7172738bc92dfdfece65c3
parent93394a761d78503f11d05b1a7b23d5a9ccc8dad2
x86: signal: check sas_ss_size instead of sas_ss_flags()

Impact: fix redundant and incorrect check

Oleg Nesterov noticed wrt commit:

  14fc9fb: x86: signal: check signal stack overflow properly

>> No need to check SA_ONSTACK if we're already using alternate signal stack.
>
> Yes, but this also mean that we don't need sas_ss_flags() under
> "if (!onsigstack)",

Checking on_sig_stack() in sas_ss_flags() at get_sigframe() is redundant
and not correct on 64 bit. To check sas_ss_size is enough.

Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: roland@redhat.com
LKML-Reference: <49CBB54C.5080201@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/signal.c