netfilter: ctnetlink: group errors into logical errno sets
authorPablo Neira Ayuso <pablo@netfilter.org>
Mon, 9 Jun 2008 22:56:20 +0000 (15:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Jun 2008 22:56:20 +0000 (15:56 -0700)
commit0adf9d67489cd30bab8eb93f7de81a674e44e1c3
tree3b29b50ef66f4796211c36a3f098500fcd23a909
parent93f65158723ceb7078ee9a0fd4830c0de00f4b9e
netfilter: ctnetlink: group errors into logical errno sets

This patch groups ctnetlink errors into three logical sets:

* Malformed messages: if ctnetlink receives a message without some mandatory
attribute, then it returns EINVAL.
* Unsupported operations: if userspace tries to perform an unsupported
operation, then it returns EOPNOTSUPP.
* Unchangeable: if userspace tries to change some attribute of the
conntrack object that can only be set once, then it returns EBUSY.

This patch reduces the number of -EINVAL from 23 to 14 and it results in
5 -EBUSY and 6 -EOPNOTSUPP.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_conntrack_netlink.c