ASoC: Remove unneeded suspend bias managment from CODEC drivers
[safe/jmp/linux-2.6] / sound / soc / codecs / wm8731.c
index 9adbd2d..c4b6353 100644 (file)
 #include <linux/pm.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
-#include <sound/driver.h>
+#include <linux/regulator/consumer.h>
+#include <linux/spi/spi.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
 #include <sound/soc-dapm.h>
 #include <sound/initval.h>
+#include <sound/tlv.h>
 
 #include "wm8731.h"
 
-#define AUDIO_NAME "wm8731"
-#define WM8731_VERSION "0.12"
-
-/*
- * Debug
- */
+static struct snd_soc_codec *wm8731_codec;
+struct snd_soc_codec_device soc_codec_dev_wm8731;
 
-#define WM8731_DEBUG 0
+#define WM8731_NUM_SUPPLIES 4
+static const char *wm8731_supply_names[WM8731_NUM_SUPPLIES] = {
+       "AVDD",
+       "HPVDD",
+       "DCVDD",
+       "DBVDD",
+};
 
-#ifdef WM8731_DEBUG
-#define dbg(format, arg...) \
-       printk(KERN_DEBUG AUDIO_NAME ": " format "\n" , ## arg)
-#else
-#define dbg(format, arg...) do {} while (0)
-#endif
-#define err(format, arg...) \
-       printk(KERN_ERR AUDIO_NAME ": " format "\n" , ## arg)
-#define info(format, arg...) \
-       printk(KERN_INFO AUDIO_NAME ": " format "\n" , ## arg)
-#define warn(format, arg...) \
-       printk(KERN_WARNING AUDIO_NAME ": " format "\n" , ## arg)
+/* codec private data */
+struct wm8731_priv {
+       struct snd_soc_codec codec;
+       struct regulator_bulk_data supplies[WM8731_NUM_SUPPLIES];
+       u16 reg_cache[WM8731_CACHEREGNUM];
+       unsigned int sysclk;
+};
 
-struct snd_soc_codec_device soc_codec_dev_wm8731;
 
 /*
  * wm8731 register cache
@@ -60,236 +58,12 @@ struct snd_soc_codec_device soc_codec_dev_wm8731;
  * There is no point in caching the reset register
  */
 static const u16 wm8731_reg[WM8731_CACHEREGNUM] = {
-    0x0097, 0x0097, 0x0079, 0x0079,
-    0x000a, 0x0008, 0x009f, 0x000a,
-    0x0000, 0x0000
+       0x0097, 0x0097, 0x0079, 0x0079,
+       0x000a, 0x0008, 0x009f, 0x000a,
+       0x0000, 0x0000
 };
 
-#define WM8731_DAIFMT \
-       (SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_RIGHT_J | \
-       SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_NB_IF | SND_SOC_DAIFMT_IB_NF | \
-       SND_SOC_DAIFMT_IB_IF)
-
-#define WM8731_DIR \
-       (SND_SOC_DAIDIR_PLAYBACK | SND_SOC_DAIDIR_CAPTURE)
-
-#define WM8731_RATES \
-       (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 | SNDRV_PCM_RATE_16000 | \
-       SNDRV_PCM_RATE_22050 | SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | \
-       SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000)
-
-#define WM8731_HIFI_BITS \
-       (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
-       SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
-
-static struct snd_soc_dai_mode wm8731_modes[] = {
-       /* codec frame and clock master modes */
-       /* 8k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .fs = 1536,
-               .bfs = SND_SOC_FSB(64),
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .fs = 2304,
-               .bfs = SND_SOC_FSB(64),
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .fs = 1408,
-               .bfs = SND_SOC_FSB(64),
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .fs = 2112,
-               .bfs = SND_SOC_FSB(64),
-       },
-
-       /* 32k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_32000,
-               .pcmdir = WM8731_DIR,
-               .fs = 384,
-               .bfs = SND_SOC_FSB(64),
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_32000,
-               .pcmdir = WM8731_DIR,
-               .fs = 576,
-               .bfs = SND_SOC_FSB(64),
-       },
-
-       /* 44.1k & 48k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .fs = 256,
-               .bfs = SND_SOC_FSB(64),
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .fs = 384,
-               .bfs = SND_SOC_FSB(64),
-       },
-
-       /* 88.2 & 96k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .fs = 128,
-               .bfs = SND_SOC_FSB(64),
-               
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .fs = 192,
-               .bfs = SND_SOC_FSB(64),
-       },
-
-       /* USB codec frame and clock master modes */
-       /* 8k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 1500,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 44.1k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 272,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 48k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 250,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 88.2k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 136,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 96k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 125,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* codec frame and clock slave modes */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBS_CFS,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = WM8731_RATES,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = SND_SOC_FS_ALL,
-               .bfs = SND_SOC_FSBD_ALL,
-       },
-};
-
-/*
- * read wm8731 register cache
- */
-static inline unsigned int wm8731_read_reg_cache(struct snd_soc_codec *codec,
-       unsigned int reg)
-{
-       u16 *cache = codec->reg_cache;
-       if (reg == WM8731_RESET)
-               return 0;
-       if (reg >= WM8731_CACHEREGNUM)
-               return -1;
-       return cache[reg];
-}
-
-/*
- * write wm8731 register cache
- */
-static inline void wm8731_write_reg_cache(struct snd_soc_codec *codec,
-       u16 reg, unsigned int value)
-{
-       u16 *cache = codec->reg_cache;
-       if (reg >= WM8731_CACHEREGNUM)
-               return;
-       cache[reg] = value;
-}
-
-/*
- * write to the WM8731 register space
- */
-static int wm8731_write(struct snd_soc_codec *codec, unsigned int reg,
-       unsigned int value)
-{
-       u8 data[2];
-
-       /* data is
-        *   D15..D9 WM8731 register offset
-        *   D8...D0 register data
-        */
-       data[0] = (reg << 1) | ((value >> 8) & 0x0001);
-       data[1] = value & 0x00ff;
-
-       wm8731_write_reg_cache (codec, reg, value);
-       if (codec->hw_write(codec->control_data, data, 2) == 2)
-               return 0;
-       else
-               return -EIO;
-}
-
-#define wm8731_reset(c)        wm8731_write(c, WM8731_RESET, 0)
+#define wm8731_reset(c)        snd_soc_write(c, WM8731_RESET, 0)
 
 static const char *wm8731_input_select[] = {"Line In", "Mic"};
 static const char *wm8731_deemph[] = {"None", "32Khz", "44.1Khz", "48Khz"};
@@ -299,18 +73,26 @@ static const struct soc_enum wm8731_enum[] = {
        SOC_ENUM_SINGLE(WM8731_APDIGI, 1, 4, wm8731_deemph),
 };
 
+static const DECLARE_TLV_DB_SCALE(in_tlv, -3450, 150, 0);
+static const DECLARE_TLV_DB_SCALE(sidetone_tlv, -1500, 300, 0);
+static const DECLARE_TLV_DB_SCALE(out_tlv, -12100, 100, 1);
+
 static const struct snd_kcontrol_new wm8731_snd_controls[] = {
 
-SOC_DOUBLE_R("Playback Volume", WM8731_LOUT1V, WM8731_ROUT1V, 0, 127, 0),
-SOC_DOUBLE_R("Playback ZC Switch", WM8731_LOUT1V, WM8731_ROUT1V, 7, 1, 0),
+SOC_DOUBLE_R_TLV("Master Playback Volume", WM8731_LOUT1V, WM8731_ROUT1V,
+                0, 127, 0, out_tlv),
+SOC_DOUBLE_R("Master Playback ZC Switch", WM8731_LOUT1V, WM8731_ROUT1V,
+       7, 1, 0),
 
-SOC_DOUBLE_R("Capture Volume", WM8731_LINVOL, WM8731_RINVOL, 0, 31, 0),
+SOC_DOUBLE_R_TLV("Capture Volume", WM8731_LINVOL, WM8731_RINVOL, 0, 31, 0,
+                in_tlv),
 SOC_DOUBLE_R("Line Capture Switch", WM8731_LINVOL, WM8731_RINVOL, 7, 1, 1),
 
 SOC_SINGLE("Mic Boost (+20dB)", WM8731_APANA, 0, 1, 0),
-SOC_SINGLE("Capture Mic Switch", WM8731_APANA, 1, 1, 1),
+SOC_SINGLE("Mic Capture Switch", WM8731_APANA, 1, 1, 1),
 
-SOC_SINGLE("Sidetone Playback Volume", WM8731_APANA, 6, 3, 1),
+SOC_SINGLE_TLV("Sidetone Playback Volume", WM8731_APANA, 6, 3, 1,
+              sidetone_tlv),
 
 SOC_SINGLE("ADC High Pass Filter Switch", WM8731_APDIGI, 0, 1, 1),
 SOC_SINGLE("Store DC Offset Switch", WM8731_APDIGI, 4, 1, 0),
@@ -318,20 +100,6 @@ SOC_SINGLE("Store DC Offset Switch", WM8731_APDIGI, 4, 1, 0),
 SOC_ENUM("Playback De-emphasis", wm8731_enum[1]),
 };
 
-/* add non dapm controls */
-static int wm8731_add_controls(struct snd_soc_codec *codec)
-{
-       int err, i;
-
-       for (i = 0; i < ARRAY_SIZE(wm8731_snd_controls); i++) {
-               if ((err = snd_ctl_add(codec->card,
-                               snd_soc_cnew(&wm8731_snd_controls[i],codec, NULL))) < 0)
-                       return err;
-       }
-
-       return 0;
-}
-
 /* Output Mixer */
 static const struct snd_kcontrol_new wm8731_output_mixer_controls[] = {
 SOC_DAPM_SINGLE("Line Bypass Switch", WM8731_APANA, 3, 1, 0),
@@ -361,7 +129,7 @@ SND_SOC_DAPM_INPUT("RLINEIN"),
 SND_SOC_DAPM_INPUT("LLINEIN"),
 };
 
-static const char *intercon[][3] = {
+static const struct snd_soc_dapm_route intercon[] = {
        /* output mixer */
        {"Output Mixer", "Line Bypass Switch", "Line Input"},
        {"Output Mixer", "HiFi Playback Switch", "DAC"},
@@ -382,26 +150,15 @@ static const char *intercon[][3] = {
        {"Line Input", NULL, "LLINEIN"},
        {"Line Input", NULL, "RLINEIN"},
        {"Mic Bias", NULL, "MICIN"},
-
-       /* terminator */
-       {NULL, NULL, NULL},
 };
 
 static int wm8731_add_widgets(struct snd_soc_codec *codec)
 {
-       int i;
-
-       for(i = 0; i < ARRAY_SIZE(wm8731_dapm_widgets); i++) {
-               snd_soc_dapm_new_control(codec, &wm8731_dapm_widgets[i]);
-       }
+       snd_soc_dapm_new_controls(codec, wm8731_dapm_widgets,
+                                 ARRAY_SIZE(wm8731_dapm_widgets));
 
-       /* set up audio path interconnects */
-       for(i = 0; intercon[i][0] != NULL; i++) {
-               snd_soc_dapm_connect_input(codec, intercon[i][0],
-                       intercon[i][1], intercon[i][2]);
-       }
+       snd_soc_dapm_add_routes(codec, intercon, ARRAY_SIZE(intercon));
 
-       snd_soc_dapm_new_widgets(codec);
        return 0;
 }
 
@@ -424,6 +181,7 @@ static const struct _coeff_div coeff_div[] = {
        /* 32k */
        {12288000, 32000, 384, 0x6, 0x0, 0x0},
        {18432000, 32000, 576, 0x6, 0x1, 0x0},
+       {12000000, 32000, 375, 0x6, 0x0, 0x1},
 
        /* 8k */
        {12288000, 8000, 1536, 0x3, 0x0, 0x0},
@@ -459,43 +217,114 @@ static inline int get_coeff(int mclk, int rate)
        return 0;
 }
 
-/* WM8731 supports numerous clocks per sample rate */
-static unsigned int wm8731_config_sysclk(struct snd_soc_codec_dai *dai,
-       struct snd_soc_clock_info *info, unsigned int clk)
+static int wm8731_hw_params(struct snd_pcm_substream *substream,
+                           struct snd_pcm_hw_params *params,
+                           struct snd_soc_dai *dai)
 {
-       dai->mclk = 0;
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
+       u16 iface = snd_soc_read(codec, WM8731_IFACE) & 0xfff3;
+       int i = get_coeff(wm8731->sysclk, params_rate(params));
+       u16 srate = (coeff_div[i].sr << 2) |
+               (coeff_div[i].bosr << 1) | coeff_div[i].usb;
+
+       snd_soc_write(codec, WM8731_SRATE, srate);
 
-       /* check that the calculated FS and rate actually match a clock from
-        * the machine driver */
-       if (info->fs * info->rate == clk)
-               dai->mclk = clk;
+       /* bit size */
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               break;
+       case SNDRV_PCM_FORMAT_S20_3LE:
+               iface |= 0x0004;
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               iface |= 0x0008;
+               break;
+       }
 
-       return dai->mclk;
+       snd_soc_write(codec, WM8731_IFACE, iface);
+       return 0;
 }
 
-static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
+static int wm8731_pcm_prepare(struct snd_pcm_substream *substream,
+                             struct snd_soc_dai *dai)
 {
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
-       struct snd_soc_codec *codec = socdev->codec;
-       u16 iface = 0, srate;
-       int i = get_coeff(rtd->codec_dai->mclk,
-               snd_soc_get_rate(rtd->codec_dai->dai_runtime.pcmrate));
+       struct snd_soc_codec *codec = socdev->card->codec;
+
+       /* set active */
+       snd_soc_write(codec, WM8731_ACTIVE, 0x0001);
+
+       return 0;
+}
+
+static void wm8731_shutdown(struct snd_pcm_substream *substream,
+                           struct snd_soc_dai *dai)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->card->codec;
+
+       /* deactivate */
+       if (!codec->active) {
+               udelay(50);
+               snd_soc_write(codec, WM8731_ACTIVE, 0x0);
+       }
+}
+
+static int wm8731_mute(struct snd_soc_dai *dai, int mute)
+{
+       struct snd_soc_codec *codec = dai->codec;
+       u16 mute_reg = snd_soc_read(codec, WM8731_APDIGI) & 0xfff7;
+
+       if (mute)
+               snd_soc_write(codec, WM8731_APDIGI, mute_reg | 0x8);
+       else
+               snd_soc_write(codec, WM8731_APDIGI, mute_reg);
+       return 0;
+}
+
+static int wm8731_set_dai_sysclk(struct snd_soc_dai *codec_dai,
+               int clk_id, unsigned int freq, int dir)
+{
+       struct snd_soc_codec *codec = codec_dai->codec;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
+
+       switch (freq) {
+       case 11289600:
+       case 12000000:
+       case 12288000:
+       case 16934400:
+       case 18432000:
+               wm8731->sysclk = freq;
+               return 0;
+       }
+       return -EINVAL;
+}
+
+
+static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
+               unsigned int fmt)
+{
+       struct snd_soc_codec *codec = codec_dai->codec;
+       u16 iface = 0;
 
        /* set master/slave audio interface */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_CLOCK_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBM_CFM:
                iface |= 0x0040;
                break;
        case SND_SOC_DAIFMT_CBS_CFS:
                break;
+       default:
+               return -EINVAL;
        }
-       srate = (coeff_div[i].sr << 2) |
-               (coeff_div[i].bosr << 1) | coeff_div[i].usb;
-       wm8731_write(codec, WM8731_SRATE, srate);
 
        /* interface format */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
        case SND_SOC_DAIFMT_I2S:
                iface |= 0x0002;
                break;
@@ -510,25 +339,12 @@ static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
        case SND_SOC_DAIFMT_DSP_B:
                iface |= 0x0013;
                break;
-       }
-
-       /* bit size */
-       switch (rtd->codec_dai->dai_runtime.pcmfmt) {
-       case SNDRV_PCM_FMTBIT_S16_LE:
-               break;
-       case SNDRV_PCM_FMTBIT_S20_3LE:
-               iface |= 0x0004;
-               break;
-       case SNDRV_PCM_FMTBIT_S24_LE:
-               iface |= 0x0008;
-               break;
-       case SNDRV_PCM_FMTBIT_S32_LE:
-               iface |= 0x000c;
-               break;
+       default:
+               return -EINVAL;
        }
 
        /* clock inversion */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_INV_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
        case SND_SOC_DAIFMT_NB_NF:
                break;
        case SND_SOC_DAIFMT_IB_IF:
@@ -540,335 +356,392 @@ static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
        case SND_SOC_DAIFMT_NB_IF:
                iface |= 0x0010;
                break;
+       default:
+               return -EINVAL;
        }
 
        /* set iface */
-       wm8731_write(codec, WM8731_IFACE, iface);
-
-       /* set active */
-       wm8731_write(codec, WM8731_ACTIVE, 0x0001);
+       snd_soc_write(codec, WM8731_IFACE, iface);
        return 0;
 }
 
-static void wm8731_shutdown(struct snd_pcm_substream *substream)
+static int wm8731_set_bias_level(struct snd_soc_codec *codec,
+                                enum snd_soc_bias_level level)
 {
-       struct snd_soc_pcm_runtime *rtd = substream->private_data;
-       struct snd_soc_device *socdev = rtd->socdev;
-       struct snd_soc_codec *codec = socdev->codec;
-
-       /* deactivate */
-       if (!codec->active) {
-               udelay(50);
-               wm8731_write(codec, WM8731_ACTIVE, 0x0);
-       }
-}
+       u16 reg;
 
-static int wm8731_mute(struct snd_soc_codec *codec,
-       struct snd_soc_codec_dai *dai, int mute)
-{
-       u16 mute_reg = wm8731_read_reg_cache(codec, WM8731_APDIGI) & 0xfff7;
-       if (mute)
-               wm8731_write(codec, WM8731_APDIGI, mute_reg | 0x8);
-       else
-               wm8731_write(codec, WM8731_APDIGI, mute_reg);
-       return 0;
-}
-
-static int wm8731_dapm_event(struct snd_soc_codec *codec, int event)
-{
-       u16 reg = wm8731_read_reg_cache(codec, WM8731_PWR) & 0xff7f;
-
-       switch (event) {
-       case SNDRV_CTL_POWER_D0: /* full On */
-               /* vref/mid, osc on, dac unmute */
-               wm8731_write(codec, WM8731_PWR, reg);
+       switch (level) {
+       case SND_SOC_BIAS_ON:
                break;
-       case SNDRV_CTL_POWER_D1: /* partial On */
-       case SNDRV_CTL_POWER_D2: /* partial On */
+       case SND_SOC_BIAS_PREPARE:
                break;
-       case SNDRV_CTL_POWER_D3hot: /* Off, with power */
-               /* everything off except vref/vmid, */
-               wm8731_write(codec, WM8731_PWR, reg | 0x0040);
+       case SND_SOC_BIAS_STANDBY:
+               /* Clear PWROFF, gate CLKOUT, everything else as-is */
+               reg = snd_soc_read(codec, WM8731_PWR) & 0xff7f;
+               snd_soc_write(codec, WM8731_PWR, reg | 0x0040);
                break;
-       case SNDRV_CTL_POWER_D3cold: /* Off, without power */
-               /* everything off, dac mute, inactive */
-               wm8731_write(codec, WM8731_ACTIVE, 0x0);
-               wm8731_write(codec, WM8731_PWR, 0xffff);
+       case SND_SOC_BIAS_OFF:
+               snd_soc_write(codec, WM8731_ACTIVE, 0x0);
+               snd_soc_write(codec, WM8731_PWR, 0xffff);
                break;
        }
-       codec->dapm_state = event;
+       codec->bias_level = level;
        return 0;
 }
 
-struct snd_soc_codec_dai wm8731_dai = {
+#define WM8731_RATES SNDRV_PCM_RATE_8000_96000
+
+#define WM8731_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
+       SNDRV_PCM_FMTBIT_S24_LE)
+
+static struct snd_soc_dai_ops wm8731_dai_ops = {
+       .prepare        = wm8731_pcm_prepare,
+       .hw_params      = wm8731_hw_params,
+       .shutdown       = wm8731_shutdown,
+       .digital_mute   = wm8731_mute,
+       .set_sysclk     = wm8731_set_dai_sysclk,
+       .set_fmt        = wm8731_set_dai_fmt,
+};
+
+struct snd_soc_dai wm8731_dai = {
        .name = "WM8731",
        .playback = {
                .stream_name = "Playback",
                .channels_min = 1,
                .channels_max = 2,
-       },
+               .rates = WM8731_RATES,
+               .formats = WM8731_FORMATS,},
        .capture = {
                .stream_name = "Capture",
                .channels_min = 1,
                .channels_max = 2,
-       },
-       .config_sysclk = wm8731_config_sysclk,
-       .digital_mute = wm8731_mute,
-       .ops = {
-               .prepare = wm8731_pcm_prepare,
-               .shutdown = wm8731_shutdown,
-       },
-       .caps = {
-               .num_modes = ARRAY_SIZE(wm8731_modes),
-               .mode = wm8731_modes,
-       },
+               .rates = WM8731_RATES,
+               .formats = WM8731_FORMATS,},
+       .ops = &wm8731_dai_ops,
+       .symmetric_rates = 1,
 };
 EXPORT_SYMBOL_GPL(wm8731_dai);
 
+#ifdef CONFIG_PM
 static int wm8731_suspend(struct platform_device *pdev, pm_message_t state)
 {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->codec;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
 
-       wm8731_write(codec, WM8731_ACTIVE, 0x0);
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3cold);
+       snd_soc_write(codec, WM8731_ACTIVE, 0x0);
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);
+       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies),
+                              wm8731->supplies);
        return 0;
 }
 
 static int wm8731_resume(struct platform_device *pdev)
 {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->codec;
-       int i;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
+       int i, ret;
        u8 data[2];
        u16 *cache = codec->reg_cache;
 
+       ret = regulator_bulk_enable(ARRAY_SIZE(wm8731->supplies),
+                                   wm8731->supplies);
+       if (ret != 0)
+               return ret;
+
        /* Sync reg_cache with the hardware */
        for (i = 0; i < ARRAY_SIZE(wm8731_reg); i++) {
+               if (cache[i] == wm8731_reg[i])
+                       continue;
+
                data[0] = (i << 1) | ((cache[i] >> 8) & 0x0001);
                data[1] = cache[i] & 0x00ff;
                codec->hw_write(codec->control_data, data, 2);
        }
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3hot);
-       wm8731_dapm_event(codec, codec->suspend_dapm_state);
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+
        return 0;
 }
+#else
+#define wm8731_suspend NULL
+#define wm8731_resume NULL
+#endif
 
-/*
- * initialise the WM8731 driver
- * register the mixer and dsp interfaces with the kernel
- */
-static int wm8731_init(struct snd_soc_device *socdev)
+static int wm8731_probe(struct platform_device *pdev)
 {
-       struct snd_soc_codec *codec = socdev->codec;
-       int reg, ret = 0;
-
-       codec->name = "WM8731";
-       codec->owner = THIS_MODULE;
-       codec->read = wm8731_read_reg_cache;
-       codec->write = wm8731_write;
-       codec->dapm_event = wm8731_dapm_event;
-       codec->dai = &wm8731_dai;
-       codec->num_dai = 1;
-       codec->reg_cache_size = ARRAY_SIZE(wm8731_reg);
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+       struct snd_soc_codec *codec;
+       int ret = 0;
 
-       codec->reg_cache =
-                       kzalloc(sizeof(u16) * ARRAY_SIZE(wm8731_reg), GFP_KERNEL);
-       if (codec->reg_cache == NULL)
-               return -ENOMEM;
-       memcpy(codec->reg_cache,
-               wm8731_reg, sizeof(u16) * ARRAY_SIZE(wm8731_reg));
-       codec->reg_cache_size = sizeof(u16) * ARRAY_SIZE(wm8731_reg);
+       if (wm8731_codec == NULL) {
+               dev_err(&pdev->dev, "Codec device not registered\n");
+               return -ENODEV;
+       }
 
-       wm8731_reset(codec);
+       socdev->card->codec = wm8731_codec;
+       codec = wm8731_codec;
 
        /* register pcms */
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
        if (ret < 0) {
-               kfree(codec->reg_cache);
-               return ret;
+               dev_err(codec->dev, "failed to create pcms: %d\n", ret);
+               goto pcm_err;
        }
 
-       /* power on device */
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3hot);
-
-       /* set the update bits */
-       reg = wm8731_read_reg_cache(codec, WM8731_LOUT1V);
-       wm8731_write(codec, WM8731_LOUT1V, reg | 0x0100);
-       reg = wm8731_read_reg_cache(codec, WM8731_ROUT1V);
-       wm8731_write(codec, WM8731_ROUT1V, reg | 0x0100);
-       reg = wm8731_read_reg_cache(codec, WM8731_LINVOL);
-       wm8731_write(codec, WM8731_LINVOL, reg | 0x0100);
-       reg = wm8731_read_reg_cache(codec, WM8731_RINVOL);
-       wm8731_write(codec, WM8731_RINVOL, reg | 0x0100);
-
-       wm8731_add_controls(codec);
+       snd_soc_add_controls(codec, wm8731_snd_controls,
+                            ARRAY_SIZE(wm8731_snd_controls));
        wm8731_add_widgets(codec);
-       ret = snd_soc_register_card(socdev);
-       if (ret < 0) {
-               snd_soc_free_pcms(socdev);
-               snd_soc_dapm_free(socdev);
-       }
 
        return ret;
+
+pcm_err:
+       return ret;
 }
 
-static struct snd_soc_device *wm8731_socdev;
+/* power down chip */
+static int wm8731_remove(struct platform_device *pdev)
+{
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
 
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
+       snd_soc_free_pcms(socdev);
+       snd_soc_dapm_free(socdev);
 
-/*
- * WM8731 2 wire address is determined by GPIO5
- * state during powerup.
- *    low  = 0x1a
- *    high = 0x1b
- */
-static unsigned short normal_i2c[] = { 0, I2C_CLIENT_END };
+       return 0;
+}
 
-/* Magic definition of all other variables and things */
-I2C_CLIENT_INSMOD;
+struct snd_soc_codec_device soc_codec_dev_wm8731 = {
+       .probe =        wm8731_probe,
+       .remove =       wm8731_remove,
+       .suspend =      wm8731_suspend,
+       .resume =       wm8731_resume,
+};
+EXPORT_SYMBOL_GPL(soc_codec_dev_wm8731);
 
-static struct i2c_driver wm8731_i2c_driver;
-static struct i2c_client client_template;
+static int wm8731_register(struct wm8731_priv *wm8731,
+                          enum snd_soc_control_type control)
+{
+       int ret, i;
+       struct snd_soc_codec *codec = &wm8731->codec;
 
-/* If the i2c layer weren't so broken, we could pass this kind of data
-   around */
+       if (wm8731_codec) {
+               dev_err(codec->dev, "Another WM8731 is registered\n");
+               ret = -EINVAL;
+               goto err;
+       }
 
-static int wm8731_codec_probe(struct i2c_adapter *adap, int addr, int kind)
-{
-       struct snd_soc_device *socdev = wm8731_socdev;
-       struct wm8731_setup_data *setup = socdev->codec_data;
-       struct snd_soc_codec *codec = socdev->codec;
-       struct i2c_client *i2c;
-       int ret;
+       mutex_init(&codec->mutex);
+       INIT_LIST_HEAD(&codec->dapm_widgets);
+       INIT_LIST_HEAD(&codec->dapm_paths);
 
-       if (addr != setup->i2c_address)
-               return -ENODEV;
+       snd_soc_codec_set_drvdata(codec, wm8731);
+       codec->name = "WM8731";
+       codec->owner = THIS_MODULE;
+       codec->bias_level = SND_SOC_BIAS_OFF;
+       codec->set_bias_level = wm8731_set_bias_level;
+       codec->dai = &wm8731_dai;
+       codec->num_dai = 1;
+       codec->reg_cache_size = WM8731_CACHEREGNUM;
+       codec->reg_cache = &wm8731->reg_cache;
 
-       client_template.adapter = adap;
-       client_template.addr = addr;
+       memcpy(codec->reg_cache, wm8731_reg, sizeof(wm8731_reg));
 
-       i2c = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-       if (i2c == NULL) {
-               kfree(codec);
-               return -ENOMEM;
+       ret = snd_soc_codec_set_cache_io(codec, 7, 9, control);
+       if (ret < 0) {
+               dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
+               goto err;
        }
-       memcpy(i2c, &client_template, sizeof(struct i2c_client));
-       i2c_set_clientdata(i2c, codec);
-       codec->control_data = i2c;
 
-       ret = i2c_attach_client(i2c);
-       if (ret < 0) {
-               err("failed to attach codec at addr %x\n", addr);
+       for (i = 0; i < ARRAY_SIZE(wm8731->supplies); i++)
+               wm8731->supplies[i].supply = wm8731_supply_names[i];
+
+       ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies),
+                                wm8731->supplies);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to request supplies: %d\n", ret);
                goto err;
        }
 
-       ret = wm8731_init(socdev);
+       ret = regulator_bulk_enable(ARRAY_SIZE(wm8731->supplies),
+                                   wm8731->supplies);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);
+               goto err_regulator_get;
+       }
+
+       ret = wm8731_reset(codec);
        if (ret < 0) {
-               err("failed to initialise WM8731\n");
-               goto err;
+               dev_err(codec->dev, "Failed to issue reset: %d\n", ret);
+               goto err_regulator_enable;
        }
-       return ret;
 
+       wm8731_dai.dev = codec->dev;
+
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+
+       /* Latch the update bits */
+       snd_soc_update_bits(codec, WM8731_LOUT1V, 0x100, 0);
+       snd_soc_update_bits(codec, WM8731_ROUT1V, 0x100, 0);
+       snd_soc_update_bits(codec, WM8731_LINVOL, 0x100, 0);
+       snd_soc_update_bits(codec, WM8731_RINVOL, 0x100, 0);
+
+       /* Disable bypass path by default */
+       snd_soc_update_bits(codec, WM8731_APANA, 0x4, 0);
+
+       wm8731_codec = codec;
+
+       ret = snd_soc_register_codec(codec);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register codec: %d\n", ret);
+               goto err_regulator_enable;
+       }
+
+       ret = snd_soc_register_dai(&wm8731_dai);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register DAI: %d\n", ret);
+               snd_soc_unregister_codec(codec);
+               goto err_codec;
+       }
+
+       return 0;
+
+err_codec:
+       snd_soc_unregister_codec(codec);
+err_regulator_enable:
+       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
+err_regulator_get:
+       regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
 err:
-       kfree(codec);
-       kfree(i2c);
+       kfree(wm8731);
        return ret;
 }
 
-static int wm8731_i2c_detach(struct i2c_client *client)
+static void wm8731_unregister(struct wm8731_priv *wm8731)
 {
-       struct snd_soc_codec* codec = i2c_get_clientdata(client);
-       i2c_detach_client(client);
-       kfree(codec->reg_cache);
-       kfree(client);
-       return 0;
+       wm8731_set_bias_level(&wm8731->codec, SND_SOC_BIAS_OFF);
+       snd_soc_unregister_dai(&wm8731_dai);
+       snd_soc_unregister_codec(&wm8731->codec);
+       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
+       regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
+       kfree(wm8731);
+       wm8731_codec = NULL;
 }
 
-static int wm8731_i2c_attach(struct i2c_adapter *adap)
+#if defined(CONFIG_SPI_MASTER)
+static int __devinit wm8731_spi_probe(struct spi_device *spi)
 {
-       return i2c_probe(adap, &addr_data, wm8731_codec_probe);
+       struct snd_soc_codec *codec;
+       struct wm8731_priv *wm8731;
+
+       wm8731 = kzalloc(sizeof(struct wm8731_priv), GFP_KERNEL);
+       if (wm8731 == NULL)
+               return -ENOMEM;
+
+       codec = &wm8731->codec;
+       codec->control_data = spi;
+       codec->dev = &spi->dev;
+
+       dev_set_drvdata(&spi->dev, wm8731);
+
+       return wm8731_register(wm8731, SND_SOC_SPI);
 }
 
-/* corgi i2c codec control layer */
-static struct i2c_driver wm8731_i2c_driver = {
+static int __devexit wm8731_spi_remove(struct spi_device *spi)
+{
+       struct wm8731_priv *wm8731 = dev_get_drvdata(&spi->dev);
+
+       wm8731_unregister(wm8731);
+
+       return 0;
+}
+
+static struct spi_driver wm8731_spi_driver = {
        .driver = {
-               .name = "WM8731 I2C Codec",
-               .owner = THIS_MODULE,
+               .name   = "wm8731",
+               .bus    = &spi_bus_type,
+               .owner  = THIS_MODULE,
        },
-       .id =             I2C_DRIVERID_WM8731,
-       .attach_adapter = wm8731_i2c_attach,
-       .detach_client =  wm8731_i2c_detach,
-       .command =        NULL,
+       .probe          = wm8731_spi_probe,
+       .remove         = __devexit_p(wm8731_spi_remove),
 };
+#endif /* CONFIG_SPI_MASTER */
 
-static struct i2c_client client_template = {
-       .name =   "WM8731",
-       .driver = &wm8731_i2c_driver,
-};
-#endif
-
-static int wm8731_probe(struct platform_device *pdev)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+static __devinit int wm8731_i2c_probe(struct i2c_client *i2c,
+                                     const struct i2c_device_id *id)
 {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct wm8731_setup_data *setup;
+       struct wm8731_priv *wm8731;
        struct snd_soc_codec *codec;
-       int ret = 0;
-
-       info("WM8731 Audio Codec %s", WM8731_VERSION);
 
-       setup = socdev->codec_data;
-       codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-       if (codec == NULL)
+       wm8731 = kzalloc(sizeof(struct wm8731_priv), GFP_KERNEL);
+       if (wm8731 == NULL)
                return -ENOMEM;
 
-       socdev->codec = codec;
-       mutex_init(&codec->mutex);
-       INIT_LIST_HEAD(&codec->dapm_widgets);
-       INIT_LIST_HEAD(&codec->dapm_paths);
+       codec = &wm8731->codec;
 
-       wm8731_socdev = socdev;
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-       if (setup->i2c_address) {
-               normal_i2c[0] = setup->i2c_address;
-               codec->hw_write = (hw_write_t)i2c_master_send;
-               ret = i2c_add_driver(&wm8731_i2c_driver);
-               if (ret != 0)
-                       printk(KERN_ERR "can't add i2c driver");
-       }
-#else
-       /* Add other interfaces here */
-#endif
-       return ret;
+       i2c_set_clientdata(i2c, wm8731);
+       codec->control_data = i2c;
+
+       codec->dev = &i2c->dev;
+
+       return wm8731_register(wm8731, SND_SOC_I2C);
 }
 
-/* power down chip */
-static int wm8731_remove(struct platform_device *pdev)
+static __devexit int wm8731_i2c_remove(struct i2c_client *client)
 {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->codec;
+       struct wm8731_priv *wm8731 = i2c_get_clientdata(client);
+       wm8731_unregister(wm8731);
+       return 0;
+}
 
-       if (codec->control_data)
-               wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3cold);
+static const struct i2c_device_id wm8731_i2c_id[] = {
+       { "wm8731", 0 },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, wm8731_i2c_id);
 
-       snd_soc_free_pcms(socdev);
-       snd_soc_dapm_free(socdev);
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-       i2c_del_driver(&wm8731_i2c_driver);
+static struct i2c_driver wm8731_i2c_driver = {
+       .driver = {
+               .name = "WM8731 I2C Codec",
+               .owner = THIS_MODULE,
+       },
+       .probe =    wm8731_i2c_probe,
+       .remove =   __devexit_p(wm8731_i2c_remove),
+       .id_table = wm8731_i2c_id,
+};
 #endif
-       kfree(codec);
 
+static int __init wm8731_modinit(void)
+{
+       int ret;
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+       ret = i2c_add_driver(&wm8731_i2c_driver);
+       if (ret != 0) {
+               printk(KERN_ERR "Failed to register WM8731 I2C driver: %d\n",
+                      ret);
+       }
+#endif
+#if defined(CONFIG_SPI_MASTER)
+       ret = spi_register_driver(&wm8731_spi_driver);
+       if (ret != 0) {
+               printk(KERN_ERR "Failed to register WM8731 SPI driver: %d\n",
+                      ret);
+       }
+#endif
        return 0;
 }
+module_init(wm8731_modinit);
 
-struct snd_soc_codec_device soc_codec_dev_wm8731 = {
-       .probe =        wm8731_probe,
-       .remove =       wm8731_remove,
-       .suspend =      wm8731_suspend,
-       .resume =       wm8731_resume,
-};
-
-EXPORT_SYMBOL_GPL(soc_codec_dev_wm8731);
+static void __exit wm8731_exit(void)
+{
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+       i2c_del_driver(&wm8731_i2c_driver);
+#endif
+#if defined(CONFIG_SPI_MASTER)
+       spi_unregister_driver(&wm8731_spi_driver);
+#endif
+}
+module_exit(wm8731_exit);
 
 MODULE_DESCRIPTION("ASoC WM8731 driver");
 MODULE_AUTHOR("Richard Purdie");