netfilter: xtables: fix mangle tables
[safe/jmp/linux-2.6] / net / ipv6 / netfilter / ip6table_mangle.c
index a98ced1..b6216de 100644 (file)
@@ -21,76 +21,17 @@ MODULE_DESCRIPTION("ip6tables mangle table");
                            (1 << NF_INET_LOCAL_OUT) | \
                            (1 << NF_INET_POST_ROUTING))
 
-static struct
-{
-       struct ip6t_replace repl;
-       struct ip6t_standard entries[5];
-       struct ip6t_error term;
-} initial_table __net_initdata = {
-       .repl = {
-               .name = "mangle",
-               .valid_hooks = MANGLE_VALID_HOOKS,
-               .num_entries = 6,
-               .size = sizeof(struct ip6t_standard) * 5 + sizeof(struct ip6t_error),
-               .hook_entry = {
-                       [NF_INET_PRE_ROUTING]   = 0,
-                       [NF_INET_LOCAL_IN]      = sizeof(struct ip6t_standard),
-                       [NF_INET_FORWARD]       = sizeof(struct ip6t_standard) * 2,
-                       [NF_INET_LOCAL_OUT]     = sizeof(struct ip6t_standard) * 3,
-                       [NF_INET_POST_ROUTING]  = sizeof(struct ip6t_standard) * 4,
-               },
-               .underflow = {
-                       [NF_INET_PRE_ROUTING]   = 0,
-                       [NF_INET_LOCAL_IN]      = sizeof(struct ip6t_standard),
-                       [NF_INET_FORWARD]       = sizeof(struct ip6t_standard) * 2,
-                       [NF_INET_LOCAL_OUT]     = sizeof(struct ip6t_standard) * 3,
-                       [NF_INET_POST_ROUTING]  = sizeof(struct ip6t_standard) * 4,
-               },
-       },
-       .entries = {
-               IP6T_STANDARD_INIT(NF_ACCEPT),  /* PRE_ROUTING */
-               IP6T_STANDARD_INIT(NF_ACCEPT),  /* LOCAL_IN */
-               IP6T_STANDARD_INIT(NF_ACCEPT),  /* FORWARD */
-               IP6T_STANDARD_INIT(NF_ACCEPT),  /* LOCAL_OUT */
-               IP6T_STANDARD_INIT(NF_ACCEPT),  /* POST_ROUTING */
-       },
-       .term = IP6T_ERROR_INIT,                /* ERROR */
-};
-
-static struct xt_table packet_mangler = {
+static const struct xt_table packet_mangler = {
        .name           = "mangle",
        .valid_hooks    = MANGLE_VALID_HOOKS,
        .me             = THIS_MODULE,
-       .af             = AF_INET6,
+       .af             = NFPROTO_IPV6,
+       .priority       = NF_IP6_PRI_MANGLE,
 };
 
-/* The work comes in here from netfilter.c. */
-static unsigned int
-ip6t_in_hook(unsigned int hook,
-        struct sk_buff *skb,
-        const struct net_device *in,
-        const struct net_device *out,
-        int (*okfn)(struct sk_buff *))
-{
-       return ip6t_do_table(skb, hook, in, out,
-                            dev_net(in)->ipv6.ip6table_mangle);
-}
-
-static unsigned int
-ip6t_post_routing_hook(unsigned int hook,
-               struct sk_buff *skb,
-               const struct net_device *in,
-               const struct net_device *out,
-               int (*okfn)(struct sk_buff *))
-{
-       return ip6t_do_table(skb, hook, in, out,
-                            dev_net(out)->ipv6.ip6table_mangle);
-}
-
 static unsigned int
 ip6t_local_out_hook(unsigned int hook,
                   struct sk_buff *skb,
-                  const struct net_device *in,
                   const struct net_device *out,
                   int (*okfn)(struct sk_buff *))
 {
@@ -102,8 +43,8 @@ ip6t_local_out_hook(unsigned int hook,
 
 #if 0
        /* root is playing with raw sockets. */
-       if (skb->len < sizeof(struct iphdr)
-           || ip_hdrlen(skb) < sizeof(struct iphdr)) {
+       if (skb->len < sizeof(struct iphdr) ||
+           ip_hdrlen(skb) < sizeof(struct iphdr)) {
                if (net_ratelimit())
                        printk("ip6t_hook: happy cracking.\n");
                return NF_ACCEPT;
@@ -119,62 +60,46 @@ ip6t_local_out_hook(unsigned int hook,
        /* flowlabel and prio (includes version, which shouldn't change either */
        flowlabel = *((u_int32_t *)ipv6_hdr(skb));
 
-       ret = ip6t_do_table(skb, hook, in, out,
+       ret = ip6t_do_table(skb, hook, NULL, out,
                            dev_net(out)->ipv6.ip6table_mangle);
 
-       if (ret != NF_DROP && ret != NF_STOLEN
-               && (memcmp(&ipv6_hdr(skb)->saddr, &saddr, sizeof(saddr))
-                   || memcmp(&ipv6_hdr(skb)->daddr, &daddr, sizeof(daddr))
-                   || skb->mark != mark
-                   || ipv6_hdr(skb)->hop_limit != hop_limit))
+       if (ret != NF_DROP && ret != NF_STOLEN &&
+           (memcmp(&ipv6_hdr(skb)->saddr, &saddr, sizeof(saddr)) ||
+            memcmp(&ipv6_hdr(skb)->daddr, &daddr, sizeof(daddr)) ||
+            skb->mark != mark ||
+            ipv6_hdr(skb)->hop_limit != hop_limit))
                return ip6_route_me_harder(skb) == 0 ? ret : NF_DROP;
 
        return ret;
 }
 
-static struct nf_hook_ops ip6t_ops[] __read_mostly = {
-       {
-               .hook           = ip6t_in_hook,
-               .owner          = THIS_MODULE,
-               .pf             = NFPROTO_IPV6,
-               .hooknum        = NF_INET_PRE_ROUTING,
-               .priority       = NF_IP6_PRI_MANGLE,
-       },
-       {
-               .hook           = ip6t_in_hook,
-               .owner          = THIS_MODULE,
-               .pf             = NFPROTO_IPV6,
-               .hooknum        = NF_INET_LOCAL_IN,
-               .priority       = NF_IP6_PRI_MANGLE,
-       },
-       {
-               .hook           = ip6t_in_hook,
-               .owner          = THIS_MODULE,
-               .pf             = NFPROTO_IPV6,
-               .hooknum        = NF_INET_FORWARD,
-               .priority       = NF_IP6_PRI_MANGLE,
-       },
-       {
-               .hook           = ip6t_local_out_hook,
-               .owner          = THIS_MODULE,
-               .pf             = NFPROTO_IPV6,
-               .hooknum        = NF_INET_LOCAL_OUT,
-               .priority       = NF_IP6_PRI_MANGLE,
-       },
-       {
-               .hook           = ip6t_post_routing_hook,
-               .owner          = THIS_MODULE,
-               .pf             = NFPROTO_IPV6,
-               .hooknum        = NF_INET_POST_ROUTING,
-               .priority       = NF_IP6_PRI_MANGLE,
-       },
-};
+/* The work comes in here from netfilter.c. */
+static unsigned int
+ip6table_mangle_hook(unsigned int hook, struct sk_buff *skb,
+                    const struct net_device *in, const struct net_device *out,
+                    int (*okfn)(struct sk_buff *))
+{
+       if (hook == NF_INET_LOCAL_OUT)
+               return ip6t_local_out_hook(hook, skb, out, okfn);
+       if (hook == NF_INET_POST_ROUTING)
+               return ip6t_do_table(skb, hook, in, out,
+                                    dev_net(out)->ipv6.ip6table_mangle);
+       /* INPUT/FORWARD */
+       return ip6t_do_table(skb, hook, in, out,
+                            dev_net(in)->ipv6.ip6table_mangle);
+}
 
+static struct nf_hook_ops *mangle_ops __read_mostly;
 static int __net_init ip6table_mangle_net_init(struct net *net)
 {
-       /* Register table */
+       struct ip6t_replace *repl;
+
+       repl = ip6t_alloc_initial_table(&packet_mangler);
+       if (repl == NULL)
+               return -ENOMEM;
        net->ipv6.ip6table_mangle =
-               ip6t_register_table(net, &packet_mangler, &initial_table.repl);
+               ip6t_register_table(net, &packet_mangler, repl);
+       kfree(repl);
        if (IS_ERR(net->ipv6.ip6table_mangle))
                return PTR_ERR(net->ipv6.ip6table_mangle);
        return 0;
@@ -182,7 +107,7 @@ static int __net_init ip6table_mangle_net_init(struct net *net)
 
 static void __net_exit ip6table_mangle_net_exit(struct net *net)
 {
-       ip6t_unregister_table(net->ipv6.ip6table_mangle);
+       ip6t_unregister_table(net, net->ipv6.ip6table_mangle);
 }
 
 static struct pernet_operations ip6table_mangle_net_ops = {
@@ -199,9 +124,11 @@ static int __init ip6table_mangle_init(void)
                return ret;
 
        /* Register hooks */
-       ret = nf_register_hooks(ip6t_ops, ARRAY_SIZE(ip6t_ops));
-       if (ret < 0)
+       mangle_ops = xt_hook_link(&packet_mangler, ip6table_mangle_hook);
+       if (IS_ERR(mangle_ops)) {
+               ret = PTR_ERR(mangle_ops);
                goto cleanup_table;
+       }
 
        return ret;
 
@@ -212,7 +139,7 @@ static int __init ip6table_mangle_init(void)
 
 static void __exit ip6table_mangle_fini(void)
 {
-       nf_unregister_hooks(ip6t_ops, ARRAY_SIZE(ip6t_ops));
+       xt_hook_unlink(&packet_mangler, mangle_ops);
        unregister_pernet_subsys(&ip6table_mangle_net_ops);
 }