net: skb->dst accessors
[safe/jmp/linux-2.6] / net / atm / br2684.c
index bdb4d89..2912665 100644 (file)
@@ -1,11 +1,12 @@
 /*
-Experimental ethernet netdevice using ATM AAL5 as underlying carrier
-(RFC1483 obsoleted by RFC2684) for Linux 2.4
-Author: Marcell GAL, 2000, XDSL Ltd, Hungary
-*/
+ * Ethernet netdevice using ATM AAL5 as underlying carrier
+ * (RFC1483 obsoleted by RFC2684) for Linux
+ *
+ * Authors: Marcell GAL, 2000, XDSL Ltd, Hungary
+ *          Eric Kinzie, 2006-2007, US Naval Research Laboratory
+ */
 
 #include <linux/module.h>
-#include <linux/config.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
@@ -18,28 +19,12 @@ Author: Marcell GAL, 2000, XDSL Ltd, Hungary
 #include <net/arp.h>
 #include <linux/atm.h>
 #include <linux/atmdev.h>
+#include <linux/capability.h>
 #include <linux/seq_file.h>
 
 #include <linux/atmbr2684.h>
 
 #include "common.h"
-#include "ipcommon.h"
-
-/*
- * Define this to use a version of the code which interacts with the higher
- * layers in a more intellegent way, by always reserving enough space for
- * our header at the begining of the packet.  However, there may still be
- * some problems with programs like tcpdump.  In 2.5 we'll sort out what
- * we need to do to get this perfect.  For now we just will copy the packet
- * if we need space for the header
- */
-/* #define FASTER_VERSION */
-
-#ifdef DEBUG
-#define DPRINTK(format, args...) printk(KERN_DEBUG "br2684: " format, ##args)
-#else
-#define DPRINTK(format, args...)
-#endif
 
 #ifdef SKB_DEBUG
 static void skb_debug(const struct sk_buff *skb)
@@ -56,38 +41,50 @@ static void skb_debug(const struct sk_buff *skb)
 #define skb_debug(skb) do {} while (0)
 #endif
 
-static unsigned char llc_oui_pid_pad[] =
-    { 0xAA, 0xAA, 0x03, 0x00, 0x80, 0xC2, 0x00, 0x07, 0x00, 0x00 };
-#define PADLEN (2)
+#define BR2684_ETHERTYPE_LEN   2
+#define BR2684_PAD_LEN         2
+
+#define LLC            0xaa, 0xaa, 0x03
+#define SNAP_BRIDGED   0x00, 0x80, 0xc2
+#define SNAP_ROUTED    0x00, 0x00, 0x00
+#define PID_ETHERNET   0x00, 0x07
+#define ETHERTYPE_IPV4 0x08, 0x00
+#define ETHERTYPE_IPV6 0x86, 0xdd
+#define PAD_BRIDGED    0x00, 0x00
+
+static const unsigned char ethertype_ipv4[] = { ETHERTYPE_IPV4 };
+static const unsigned char ethertype_ipv6[] = { ETHERTYPE_IPV6 };
+static const unsigned char llc_oui_pid_pad[] =
+                       { LLC, SNAP_BRIDGED, PID_ETHERNET, PAD_BRIDGED };
+static const unsigned char llc_oui_ipv4[] = { LLC, SNAP_ROUTED, ETHERTYPE_IPV4 };
+static const unsigned char llc_oui_ipv6[] = { LLC, SNAP_ROUTED, ETHERTYPE_IPV6 };
 
 enum br2684_encaps {
-       e_vc  = BR2684_ENCAPS_VC,
+       e_vc = BR2684_ENCAPS_VC,
        e_llc = BR2684_ENCAPS_LLC,
 };
 
 struct br2684_vcc {
-       struct atm_vcc  *atmvcc;
+       struct atm_vcc *atmvcc;
        struct net_device *device;
-       /* keep old push,pop functions for chaining */
-       void (*old_push)(struct atm_vcc *vcc,struct sk_buff *skb);
-       /* void (*old_pop)(struct atm_vcc *vcc,struct sk_buff *skb); */
+       /* keep old push, pop functions for chaining */
+       void (*old_push) (struct atm_vcc * vcc, struct sk_buff * skb);
+       /* void (*old_pop)(struct atm_vcc *vcc, struct sk_buff *skb); */
        enum br2684_encaps encaps;
        struct list_head brvccs;
 #ifdef CONFIG_ATM_BR2684_IPFILTER
        struct br2684_filter filter;
 #endif /* CONFIG_ATM_BR2684_IPFILTER */
-#ifndef FASTER_VERSION
        unsigned copies_needed, copies_failed;
-#endif /* FASTER_VERSION */
 };
 
 struct br2684_dev {
        struct net_device *net_dev;
        struct list_head br2684_devs;
        int number;
-       struct list_head brvccs; /* one device <=> one vcc (before xmas) */
-       struct net_device_stats stats;
+       struct list_head brvccs;        /* one device <=> one vcc (before xmas) */
        int mac_was_set;
+       enum br2684_payload payload;
 };
 
 /*
@@ -103,7 +100,7 @@ static LIST_HEAD(br2684_devs);
 
 static inline struct br2684_dev *BRPRIV(const struct net_device *net_dev)
 {
-       return (struct br2684_dev *) net_dev->priv;
+       return (struct br2684_dev *)netdev_priv(net_dev);
 }
 
 static inline struct net_device *list_entry_brdev(const struct list_head *le)
@@ -113,7 +110,7 @@ static inline struct net_device *list_entry_brdev(const struct list_head *le)
 
 static inline struct br2684_vcc *BR2684_VCC(const struct atm_vcc *atmvcc)
 {
-       return (struct br2684_vcc *) (atmvcc->user_back);
+       return (struct br2684_vcc *)(atmvcc->user_back);
 }
 
 static inline struct br2684_vcc *list_entry_brvcc(const struct list_head *le)
@@ -150,18 +147,13 @@ static struct net_device *br2684_find_dev(const struct br2684_if_spec *s)
  * the way for multiple vcc's per itf.  Returns true if we can send,
  * otherwise false
  */
-static int br2684_xmit_vcc(struct sk_buff *skb, struct br2684_dev *brdev,
-       struct br2684_vcc *brvcc)
+static int br2684_xmit_vcc(struct sk_buff *skb, struct net_device *dev,
+                          struct br2684_vcc *brvcc)
 {
+       struct br2684_dev *brdev = BRPRIV(dev);
        struct atm_vcc *atmvcc;
-#ifdef FASTER_VERSION
-       if (brvcc->encaps == e_llc)
-               memcpy(skb_push(skb, 8), llc_oui_pid_pad, 8);
-       /* last 2 bytes of llc_oui_pid_pad are managed by header routines;
-          yes, you got it: 8 + 2 = sizeof(llc_oui_pid_pad)
-        */
-#else
        int minheadroom = (brvcc->encaps == e_llc) ? 10 : 2;
+
        if (skb_headroom(skb) < minheadroom) {
                struct sk_buff *skb2 = skb_realloc_headroom(skb, minheadroom);
                brvcc->copies_needed++;
@@ -172,37 +164,63 @@ static int br2684_xmit_vcc(struct sk_buff *skb, struct br2684_dev *brdev,
                }
                skb = skb2;
        }
-       skb_push(skb, minheadroom);
-       if (brvcc->encaps == e_llc)
-               memcpy(skb->data, llc_oui_pid_pad, 10);
-       else
-               memset(skb->data, 0, 2);
-#endif /* FASTER_VERSION */
+
+       if (brvcc->encaps == e_llc) {
+               if (brdev->payload == p_bridged) {
+                       skb_push(skb, sizeof(llc_oui_pid_pad));
+                       skb_copy_to_linear_data(skb, llc_oui_pid_pad,
+                                               sizeof(llc_oui_pid_pad));
+               } else if (brdev->payload == p_routed) {
+                       unsigned short prot = ntohs(skb->protocol);
+
+                       skb_push(skb, sizeof(llc_oui_ipv4));
+                       switch (prot) {
+                       case ETH_P_IP:
+                               skb_copy_to_linear_data(skb, llc_oui_ipv4,
+                                                       sizeof(llc_oui_ipv4));
+                               break;
+                       case ETH_P_IPV6:
+                               skb_copy_to_linear_data(skb, llc_oui_ipv6,
+                                                       sizeof(llc_oui_ipv6));
+                               break;
+                       default:
+                               dev_kfree_skb(skb);
+                               return 0;
+                       }
+               }
+       } else { /* e_vc */
+               if (brdev->payload == p_bridged) {
+                       skb_push(skb, 2);
+                       memset(skb->data, 0, 2);
+               } else { /* p_routed */
+                       skb_pull(skb, ETH_HLEN);
+               }
+       }
        skb_debug(skb);
 
        ATM_SKB(skb)->vcc = atmvcc = brvcc->atmvcc;
-       DPRINTK("atm_skb(%p)->vcc(%p)->dev(%p)\n", skb, atmvcc, atmvcc->dev);
+       pr_debug("atm_skb(%p)->vcc(%p)->dev(%p)\n", skb, atmvcc, atmvcc->dev);
        if (!atm_may_send(atmvcc, skb->truesize)) {
-               /* we free this here for now, because we cannot know in a higher 
-                       layer whether the skb point it supplied wasn't freed yet.
-                       now, it always is.
-               */
+               /*
+                * We free this here for now, because we cannot know in a higher
+                * layer whether the skb pointer it supplied wasn't freed yet.
+                * Now, it always is.
+                */
                dev_kfree_skb(skb);
                return 0;
-               }
+       }
        atomic_add(skb->truesize, &sk_atm(atmvcc)->sk_wmem_alloc);
        ATM_SKB(skb)->atm_options = atmvcc->atm_options;
-       brdev->stats.tx_packets++;
-       brdev->stats.tx_bytes += skb->len;
+       dev->stats.tx_packets++;
+       dev->stats.tx_bytes += skb->len;
        atmvcc->send(atmvcc, skb);
        return 1;
 }
 
-static inline struct br2684_vcc *pick_outgoing_vcc(struct sk_buff *skb,
-       struct br2684_dev *brdev)
+static inline struct br2684_vcc *pick_outgoing_vcc(const struct sk_buff *skb,
+                                                  const struct br2684_dev *brdev)
 {
-       return list_empty(&brdev->brvccs) ? NULL :
-           list_entry_brvcc(brdev->brvccs.next); /* 1 vcc/dev right now */
+       return list_empty(&brdev->brvccs) ? NULL : list_entry_brvcc(brdev->brvccs.next);        /* 1 vcc/dev right now */
 }
 
 static int br2684_start_xmit(struct sk_buff *skb, struct net_device *dev)
@@ -210,130 +228,40 @@ static int br2684_start_xmit(struct sk_buff *skb, struct net_device *dev)
        struct br2684_dev *brdev = BRPRIV(dev);
        struct br2684_vcc *brvcc;
 
-       DPRINTK("br2684_start_xmit, skb->dst=%p\n", skb->dst);
+       pr_debug("br2684_start_xmit, skb_dst(skb)=%p\n", skb_dst(skb));
        read_lock(&devs_lock);
        brvcc = pick_outgoing_vcc(skb, brdev);
        if (brvcc == NULL) {
-               DPRINTK("no vcc attached to dev %s\n", dev->name);
-               brdev->stats.tx_errors++;
-               brdev->stats.tx_carrier_errors++;
+               pr_debug("no vcc attached to dev %s\n", dev->name);
+               dev->stats.tx_errors++;
+               dev->stats.tx_carrier_errors++;
                /* netif_stop_queue(dev); */
                dev_kfree_skb(skb);
                read_unlock(&devs_lock);
                return 0;
        }
-       if (!br2684_xmit_vcc(skb, brdev, brvcc)) {
+       if (!br2684_xmit_vcc(skb, dev, brvcc)) {
                /*
                 * We should probably use netif_*_queue() here, but that
                 * involves added complication.  We need to walk before
-                * we can run
+                * we can run.
+                *
+                * Don't free here! this pointer might be no longer valid!
                 */
-               /* don't free here! this pointer might be no longer valid!
-               dev_kfree_skb(skb);
-               */
-               brdev->stats.tx_errors++;
-               brdev->stats.tx_fifo_errors++;
+               dev->stats.tx_errors++;
+               dev->stats.tx_fifo_errors++;
        }
        read_unlock(&devs_lock);
        return 0;
 }
 
-static struct net_device_stats *br2684_get_stats(struct net_device *dev)
-{
-       DPRINTK("br2684_get_stats\n");
-       return &BRPRIV(dev)->stats;
-}
-
-#ifdef FASTER_VERSION
-/*
- * These mirror eth_header and eth_header_cache.  They are not usually
- * exported for use in modules, so we grab them from net_device
- * after ether_setup() is done with it.  Bit of a hack.
- */
-static int (*my_eth_header)(struct sk_buff *, struct net_device *,
-       unsigned short, void *, void *, unsigned);
-static int (*my_eth_header_cache)(struct neighbour *, struct hh_cache *);
-
-static int
-br2684_header(struct sk_buff *skb, struct net_device *dev,
-             unsigned short type, void *daddr, void *saddr, unsigned len)
-{
-       u16 *pad_before_eth;
-       int t = my_eth_header(skb, dev, type, daddr, saddr, len);
-       if (t > 0) {
-               pad_before_eth = (u16 *) skb_push(skb, 2);
-               *pad_before_eth = 0;
-               return dev->hard_header_len;    /* or return 16; ? */
-       } else
-               return t;
-}
-
-static int
-br2684_header_cache(struct neighbour *neigh, struct hh_cache *hh)
-{
-/* hh_data is 16 bytes long. if encaps is ether-llc we need 24, so
-xmit will add the additional header part in that case */
-       u16 *pad_before_eth = (u16 *)(hh->hh_data);
-       int t = my_eth_header_cache(neigh, hh);
-       DPRINTK("br2684_header_cache, neigh=%p, hh_cache=%p\n", neigh, hh);
-       if (t < 0)
-               return t;
-       else {
-               *pad_before_eth = 0;
-               hh->hh_len = PADLEN + ETH_HLEN;
-       }
-       return 0;
-}
-
-/*
- * This is similar to eth_type_trans, which cannot be used because of
- * our dev->hard_header_len
- */
-static inline __be16 br_type_trans(struct sk_buff *skb, struct net_device *dev)
-{
-       struct ethhdr *eth;
-       unsigned char *rawp;
-       eth = eth_hdr(skb);
-
-       if (is_multicast_ether_addr(eth->h_dest)) {
-               if (memcmp(eth->h_dest, dev->broadcast, ETH_ALEN) == 0)
-                       skb->pkt_type = PACKET_BROADCAST;
-               else
-                       skb->pkt_type = PACKET_MULTICAST;
-       }
-
-       else if (memcmp(eth->h_dest, dev->dev_addr, ETH_ALEN))
-               skb->pkt_type = PACKET_OTHERHOST;
-
-       if (ntohs(eth->h_proto) >= 1536)
-               return eth->h_proto;
-
-       rawp = skb->data;
-
-       /*
-        * This is a magic hack to spot IPX packets. Older Novell breaks
-        * the protocol design and runs IPX over 802.3 without an 802.2 LLC
-        * layer. We look for FFFF which isn't a used 802.2 SSAP/DSAP. This
-        * won't work for fault tolerant netware but does for the rest.
-        */
-       if (*(unsigned short *) rawp == 0xFFFF)
-               return htons(ETH_P_802_3);
-
-       /*
-        * Real 802.2 LLC
-        */
-       return htons(ETH_P_802_2);
-}
-#endif /* FASTER_VERSION */
-
 /*
  * We remember when the MAC gets set, so we don't override it later with
  * the ESI of the ATM card of the first VC
  */
-static int (*my_eth_mac_addr)(struct net_device *, void *);
 static int br2684_mac_addr(struct net_device *dev, void *p)
 {
-       int err = my_eth_mac_addr(dev, p);
+       int err = eth_mac_addr(dev, p);
        if (!err)
                BRPRIV(dev)->mac_was_set = 1;
        return err;
@@ -341,7 +269,7 @@ static int br2684_mac_addr(struct net_device *dev, void *p)
 
 #ifdef CONFIG_ATM_BR2684_IPFILTER
 /* this IOCTL is experimental. */
-static int br2684_setfilt(struct atm_vcc *atmvcc, void __user *arg)
+static int br2684_setfilt(struct atm_vcc *atmvcc, void __user * arg)
 {
        struct br2684_vcc *brvcc;
        struct br2684_filter_set fs;
@@ -351,13 +279,12 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void __user *arg)
        if (fs.ifspec.method != BR2684_FIND_BYNOTHING) {
                /*
                 * This is really a per-vcc thing, but we can also search
-                * by device
+                * by device.
                 */
                struct br2684_dev *brdev;
                read_lock(&devs_lock);
                brdev = BRPRIV(br2684_find_dev(&fs.ifspec));
-               if (brdev == NULL || list_empty(&brdev->brvccs) ||
-                   brdev->brvccs.next != brdev->brvccs.prev)  /* >1 VCC */
+               if (brdev == NULL || list_empty(&brdev->brvccs) || brdev->brvccs.next != brdev->brvccs.prev)    /* >1 VCC */
                        brvcc = NULL;
                else
                        brvcc = list_entry_brvcc(brdev->brvccs.next);
@@ -372,18 +299,19 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void __user *arg)
 
 /* Returns 1 if packet should be dropped */
 static inline int
-packet_fails_filter(u16 type, struct br2684_vcc *brvcc, struct sk_buff *skb)
+packet_fails_filter(__be16 type, struct br2684_vcc *brvcc, struct sk_buff *skb)
 {
        if (brvcc->filter.netmask == 0)
-               return 0;                       /* no filter in place */
-       if (type == __constant_htons(ETH_P_IP) &&
-           (((struct iphdr *) (skb->data))->daddr & brvcc->filter.
+               return 0;       /* no filter in place */
+       if (type == htons(ETH_P_IP) &&
+           (((struct iphdr *)(skb->data))->daddr & brvcc->filter.
             netmask) == brvcc->filter.prefix)
                return 0;
-       if (type == __constant_htons(ETH_P_ARP))
+       if (type == htons(ETH_P_ARP))
                return 0;
-       /* TODO: we should probably filter ARPs too.. don't want to have
-        *   them returning values that don't make sense, or is that ok?
+       /*
+        * TODO: we should probably filter ARPs too.. don't want to have
+        * them returning values that don't make sense, or is that ok?
         */
        return 1;               /* drop */
 }
@@ -391,7 +319,7 @@ packet_fails_filter(u16 type, struct br2684_vcc *brvcc, struct sk_buff *skb)
 
 static void br2684_close_vcc(struct br2684_vcc *brvcc)
 {
-       DPRINTK("removing VCC %p from dev %p\n", brvcc, brvcc->device);
+       pr_debug("removing VCC %p from dev %p\n", brvcc, brvcc->device);
        write_lock_irq(&devs_lock);
        list_del(&brvcc->brvccs);
        write_unlock_irq(&devs_lock);
@@ -407,17 +335,16 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
        struct br2684_vcc *brvcc = BR2684_VCC(atmvcc);
        struct net_device *net_dev = brvcc->device;
        struct br2684_dev *brdev = BRPRIV(net_dev);
-       int plen = sizeof(llc_oui_pid_pad) + ETH_HLEN;
 
-       DPRINTK("br2684_push\n");
+       pr_debug("br2684_push\n");
 
        if (unlikely(skb == NULL)) {
                /* skb==NULL means VCC is being destroyed */
                br2684_close_vcc(brvcc);
                if (list_empty(&brdev->brvccs)) {
-                       read_lock(&devs_lock);
+                       write_lock_irq(&devs_lock);
                        list_del(&brdev->br2684_devs);
-                       read_unlock(&devs_lock);
+                       write_unlock_irq(&devs_lock);
                        unregister_netdev(net_dev);
                        free_netdev(net_dev);
                }
@@ -426,97 +353,118 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
 
        skb_debug(skb);
        atm_return(atmvcc, skb->truesize);
-       DPRINTK("skb from brdev %p\n", brdev);
+       pr_debug("skb from brdev %p\n", brdev);
        if (brvcc->encaps == e_llc) {
-               /* let us waste some time for checking the encapsulation.
-                  Note, that only 7 char is checked so frames with a valid FCS
-                  are also accepted (but FCS is not checked of course) */
-               if (memcmp(skb->data, llc_oui_pid_pad, 7)) {
-                       brdev->stats.rx_errors++;
-                       dev_kfree_skb(skb);
-                       return;
-               }
 
-               /* Strip FCS if present */
                if (skb->len > 7 && skb->data[7] == 0x01)
                        __skb_trim(skb, skb->len - 4);
-       } else {
-               plen = PADLEN + ETH_HLEN;       /* pad, dstmac,srcmac, ethtype */
-               /* first 2 chars should be 0 */
-               if (*((u16 *) (skb->data)) != 0) {
-                       brdev->stats.rx_errors++;
-                       dev_kfree_skb(skb);
-                       return;
+
+               /* accept packets that have "ipv[46]" in the snap header */
+               if ((skb->len >= (sizeof(llc_oui_ipv4)))
+                   &&
+                   (memcmp
+                    (skb->data, llc_oui_ipv4,
+                     sizeof(llc_oui_ipv4) - BR2684_ETHERTYPE_LEN) == 0)) {
+                       if (memcmp
+                           (skb->data + 6, ethertype_ipv6,
+                            sizeof(ethertype_ipv6)) == 0)
+                               skb->protocol = htons(ETH_P_IPV6);
+                       else if (memcmp
+                                (skb->data + 6, ethertype_ipv4,
+                                 sizeof(ethertype_ipv4)) == 0)
+                               skb->protocol = htons(ETH_P_IP);
+                       else
+                               goto error;
+                       skb_pull(skb, sizeof(llc_oui_ipv4));
+                       skb_reset_network_header(skb);
+                       skb->pkt_type = PACKET_HOST;
+                       /*
+                        * Let us waste some time for checking the encapsulation.
+                        * Note, that only 7 char is checked so frames with a valid FCS
+                        * are also accepted (but FCS is not checked of course).
+                        */
+               } else if ((skb->len >= sizeof(llc_oui_pid_pad)) &&
+                          (memcmp(skb->data, llc_oui_pid_pad, 7) == 0)) {
+                       skb_pull(skb, sizeof(llc_oui_pid_pad));
+                       skb->protocol = eth_type_trans(skb, net_dev);
+               } else
+                       goto error;
+
+       } else { /* e_vc */
+               if (brdev->payload == p_routed) {
+                       struct iphdr *iph;
+
+                       skb_reset_network_header(skb);
+                       iph = ip_hdr(skb);
+                       if (iph->version == 4)
+                               skb->protocol = htons(ETH_P_IP);
+                       else if (iph->version == 6)
+                               skb->protocol = htons(ETH_P_IPV6);
+                       else
+                               goto error;
+                       skb->pkt_type = PACKET_HOST;
+               } else { /* p_bridged */
+                       /* first 2 chars should be 0 */
+                       if (*((u16 *) (skb->data)) != 0)
+                               goto error;
+                       skb_pull(skb, BR2684_PAD_LEN);
+                       skb->protocol = eth_type_trans(skb, net_dev);
                }
        }
-       if (skb->len < plen) {
-               brdev->stats.rx_errors++;
-               dev_kfree_skb(skb);     /* dev_ not needed? */
-               return;
-       }
 
-#ifdef FASTER_VERSION
-       /* FIXME: tcpdump shows that pointer to mac header is 2 bytes earlier,
-          than should be. What else should I set? */
-       skb_pull(skb, plen);
-       skb->mac.raw = ((char *) (skb->data)) - ETH_HLEN;
-       skb->pkt_type = PACKET_HOST;
-#ifdef CONFIG_BR2684_FAST_TRANS
-       skb->protocol = ((u16 *) skb->data)[-1];
-#else                          /* some protocols might require this: */
-       skb->protocol = br_type_trans(skb, net_dev);
-#endif /* CONFIG_BR2684_FAST_TRANS */
-#else
-       skb_pull(skb, plen - ETH_HLEN);
-       skb->protocol = eth_type_trans(skb, net_dev);
-#endif /* FASTER_VERSION */
 #ifdef CONFIG_ATM_BR2684_IPFILTER
-       if (unlikely(packet_fails_filter(skb->protocol, brvcc, skb))) {
-               brdev->stats.rx_dropped++;
-               dev_kfree_skb(skb);
-               return;
-       }
+       if (unlikely(packet_fails_filter(skb->protocol, brvcc, skb)))
+               goto dropped;
 #endif /* CONFIG_ATM_BR2684_IPFILTER */
        skb->dev = net_dev;
        ATM_SKB(skb)->vcc = atmvcc;     /* needed ? */
-       DPRINTK("received packet's protocol: %x\n", ntohs(skb->protocol));
+       pr_debug("received packet's protocol: %x\n", ntohs(skb->protocol));
        skb_debug(skb);
-       if (unlikely(!(net_dev->flags & IFF_UP))) {
-               /* sigh, interface is down */
-               brdev->stats.rx_dropped++;
-               dev_kfree_skb(skb);
-               return;
-       }
-       brdev->stats.rx_packets++;
-       brdev->stats.rx_bytes += skb->len;
+       /* sigh, interface is down? */
+       if (unlikely(!(net_dev->flags & IFF_UP)))
+               goto dropped;
+       net_dev->stats.rx_packets++;
+       net_dev->stats.rx_bytes += skb->len;
        memset(ATM_SKB(skb), 0, sizeof(struct atm_skb_data));
        netif_rx(skb);
+       return;
+
+dropped:
+       net_dev->stats.rx_dropped++;
+       goto free_skb;
+error:
+       net_dev->stats.rx_errors++;
+free_skb:
+       dev_kfree_skb(skb);
+       return;
 }
 
-static int br2684_regvcc(struct atm_vcc *atmvcc, void __user *arg)
+/*
+ * Assign a vcc to a dev
+ * Note: we do not have explicit unassign, but look at _push()
+ */
+static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
 {
-/* assign a vcc to a dev
-Note: we do not have explicit unassign, but look at _push()
-*/
+       struct sk_buff_head queue;
        int err;
        struct br2684_vcc *brvcc;
-       struct sk_buff_head copy;
-       struct sk_buff *skb;
+       struct sk_buff *skb, *tmp;
+       struct sk_buff_head *rq;
        struct br2684_dev *brdev;
        struct net_device *net_dev;
        struct atm_backend_br2684 be;
+       unsigned long flags;
 
        if (copy_from_user(&be, arg, sizeof be))
                return -EFAULT;
-       brvcc = kmalloc(sizeof(struct br2684_vcc), GFP_KERNEL);
+       brvcc = kzalloc(sizeof(struct br2684_vcc), GFP_KERNEL);
        if (!brvcc)
                return -ENOMEM;
-       memset(brvcc, 0, sizeof(struct br2684_vcc));
        write_lock_irq(&devs_lock);
        net_dev = br2684_find_dev(&be.ifspec);
        if (net_dev == NULL) {
                printk(KERN_ERR
-                   "br2684: tried to attach to non-existant device\n");
+                      "br2684: tried to attach to non-existant device\n");
                err = -ENXIO;
                goto error;
        }
@@ -532,13 +480,15 @@ Note: we do not have explicit unassign, but look at _push()
        }
        if (be.fcs_in != BR2684_FCSIN_NO || be.fcs_out != BR2684_FCSOUT_NO ||
            be.fcs_auto || be.has_vpiid || be.send_padding || (be.encaps !=
-           BR2684_ENCAPS_VC && be.encaps != BR2684_ENCAPS_LLC) ||
-           be.min_size != 0) {
+                                                              BR2684_ENCAPS_VC
+                                                              && be.encaps !=
+                                                              BR2684_ENCAPS_LLC)
+           || be.min_size != 0) {
                err = -EINVAL;
                goto error;
        }
-       DPRINTK("br2684_regvcc vcc=%p, encaps=%d, brvcc=%p\n", atmvcc, be.encaps,
-               brvcc);
+       pr_debug("br2684_regvcc vcc=%p, encaps=%d, brvcc=%p\n", atmvcc,
+                be.encaps, brvcc);
        if (list_empty(&brdev->brvccs) && !brdev->mac_was_set) {
                unsigned char *esi = atmvcc->dev->esi;
                if (esi[0] | esi[1] | esi[2] | esi[3] | esi[4] | esi[5])
@@ -551,25 +501,41 @@ Note: we do not have explicit unassign, but look at _push()
        brvcc->device = net_dev;
        brvcc->atmvcc = atmvcc;
        atmvcc->user_back = brvcc;
-       brvcc->encaps = (enum br2684_encaps) be.encaps;
+       brvcc->encaps = (enum br2684_encaps)be.encaps;
        brvcc->old_push = atmvcc->push;
        barrier();
        atmvcc->push = br2684_push;
-       skb_queue_head_init(&copy);
-       skb_migrate(&sk_atm(atmvcc)->sk_receive_queue, &copy);
-       while ((skb = skb_dequeue(&copy)) != NULL) {
-               BRPRIV(skb->dev)->stats.rx_bytes -= skb->len;
-               BRPRIV(skb->dev)->stats.rx_packets--;
+
+       __skb_queue_head_init(&queue);
+       rq = &sk_atm(atmvcc)->sk_receive_queue;
+
+       spin_lock_irqsave(&rq->lock, flags);
+       skb_queue_splice_init(rq, &queue);
+       spin_unlock_irqrestore(&rq->lock, flags);
+
+       skb_queue_walk_safe(&queue, skb, tmp) {
+               struct net_device *dev = skb->dev;
+
+               dev->stats.rx_bytes -= skb->len;
+               dev->stats.rx_packets--;
+
                br2684_push(atmvcc, skb);
        }
        __module_get(THIS_MODULE);
        return 0;
-    error:
+      error:
        write_unlock_irq(&devs_lock);
        kfree(brvcc);
        return err;
 }
 
+static const struct net_device_ops br2684_netdev_ops = {
+       .ndo_start_xmit         = br2684_start_xmit,
+       .ndo_set_mac_address    = br2684_mac_addr,
+       .ndo_change_mtu         = eth_change_mtu,
+       .ndo_validate_addr      = eth_validate_addr,
+};
+
 static void br2684_setup(struct net_device *netdev)
 {
        struct br2684_dev *brdev = BRPRIV(netdev);
@@ -577,46 +543,61 @@ static void br2684_setup(struct net_device *netdev)
        ether_setup(netdev);
        brdev->net_dev = netdev;
 
-#ifdef FASTER_VERSION
-       my_eth_header = netdev->hard_header;
-       netdev->hard_header = br2684_header;
-       my_eth_header_cache = netdev->hard_header_cache;
-       netdev->hard_header_cache = br2684_header_cache;
-       netdev->hard_header_len = sizeof(llc_oui_pid_pad) + ETH_HLEN;   /* 10 + 14 */
-#endif
-       my_eth_mac_addr = netdev->set_mac_address;
-       netdev->set_mac_address = br2684_mac_addr;
-       netdev->hard_start_xmit = br2684_start_xmit;
-       netdev->get_stats = br2684_get_stats;
+       netdev->netdev_ops = &br2684_netdev_ops;
 
        INIT_LIST_HEAD(&brdev->brvccs);
 }
 
-static int br2684_create(void __user *arg)
+static void br2684_setup_routed(struct net_device *netdev)
+{
+       struct br2684_dev *brdev = BRPRIV(netdev);
+       brdev->net_dev = netdev;
+
+       netdev->hard_header_len = 0;
+
+       netdev->netdev_ops = &br2684_netdev_ops;
+       netdev->addr_len = 0;
+       netdev->mtu = 1500;
+       netdev->type = ARPHRD_PPP;
+       netdev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
+       netdev->tx_queue_len = 100;
+       INIT_LIST_HEAD(&brdev->brvccs);
+}
+
+static int br2684_create(void __user * arg)
 {
        int err;
        struct net_device *netdev;
        struct br2684_dev *brdev;
        struct atm_newif_br2684 ni;
+       enum br2684_payload payload;
 
-       DPRINTK("br2684_create\n");
+       pr_debug("br2684_create\n");
 
        if (copy_from_user(&ni, arg, sizeof ni)) {
                return -EFAULT;
        }
+
+       if (ni.media & BR2684_FLAG_ROUTED)
+               payload = p_routed;
+       else
+               payload = p_bridged;
+       ni.media &= 0xffff;     /* strip flags */
+
        if (ni.media != BR2684_MEDIA_ETHERNET || ni.mtu != 1500) {
                return -EINVAL;
        }
 
        netdev = alloc_netdev(sizeof(struct br2684_dev),
                              ni.ifname[0] ? ni.ifname : "nas%d",
-                             br2684_setup);
+                             (payload == p_routed) ?
+                             br2684_setup_routed : br2684_setup);
        if (!netdev)
                return -ENOMEM;
 
        brdev = BRPRIV(netdev);
 
-       DPRINTK("registered netdev %s\n", netdev->name);
+       pr_debug("registered netdev %s\n", netdev->name);
        /* open, stop, do_ioctl ? */
        err = register_netdev(netdev);
        if (err < 0) {
@@ -626,6 +607,7 @@ static int br2684_create(void __user *arg)
        }
 
        write_lock_irq(&devs_lock);
+       brdev->payload = payload;
        brdev->number = list_empty(&br2684_devs) ? 1 :
            BRPRIV(list_entry_brdev(br2684_devs.prev))->number + 1;
        list_add_tail(&brdev->br2684_devs, &br2684_devs);
@@ -638,16 +620,16 @@ static int br2684_create(void __user *arg)
  * -ENOIOCTLCMD for any unrecognized ioctl
  */
 static int br2684_ioctl(struct socket *sock, unsigned int cmd,
-       unsigned long arg)
+                       unsigned long arg)
 {
        struct atm_vcc *atmvcc = ATM_SD(sock);
        void __user *argp = (void __user *)arg;
+       atm_backend_t b;
 
        int err;
-       switch(cmd) {
+       switch (cmd) {
        case ATM_SETBACKEND:
-       case ATM_NEWBACKENDIF: {
-               atm_backend_t b;
+       case ATM_NEWBACKENDIF:
                err = get_user(b, (atm_backend_t __user *) argp);
                if (err)
                        return -EFAULT;
@@ -659,7 +641,6 @@ static int br2684_ioctl(struct socket *sock, unsigned int cmd,
                        return br2684_regvcc(atmvcc, argp);
                else
                        return br2684_create(argp);
-               }
 #ifdef CONFIG_ATM_BR2684_IPFILTER
        case BR2684_SETFILT:
                if (atmvcc->push != br2684_push)
@@ -667,6 +648,7 @@ static int br2684_ioctl(struct socket *sock, unsigned int cmd,
                if (!capable(CAP_NET_ADMIN))
                        return -EPERM;
                err = br2684_setfilt(atmvcc, argp);
+
                return err;
 #endif /* CONFIG_ATM_BR2684_IPFILTER */
        }
@@ -674,80 +656,56 @@ static int br2684_ioctl(struct socket *sock, unsigned int cmd,
 }
 
 static struct atm_ioctl br2684_ioctl_ops = {
-       .owner  = THIS_MODULE,
-       .ioctl  = br2684_ioctl,
+       .owner = THIS_MODULE,
+       .ioctl = br2684_ioctl,
 };
 
-
 #ifdef CONFIG_PROC_FS
-static void *br2684_seq_start(struct seq_file *seq, loff_t *pos)
+static void *br2684_seq_start(struct seq_file *seq, loff_t * pos)
+       __acquires(devs_lock)
 {
-       loff_t offs = 0;
-       struct br2684_dev *brd;
-
        read_lock(&devs_lock);
-
-       list_for_each_entry(brd, &br2684_devs, br2684_devs) {
-               if (offs == *pos)
-                       return brd;
-               ++offs;
-       }
-       return NULL;
+       return seq_list_start(&br2684_devs, *pos);
 }
 
-static void *br2684_seq_next(struct seq_file *seq, void *v, loff_t *pos)
+static void *br2684_seq_next(struct seq_file *seq, void *v, loff_t * pos)
 {
-       struct br2684_dev *brd = v;
-
-       ++*pos;
-
-       brd = list_entry(brd->br2684_devs.next, 
-                        struct br2684_dev, br2684_devs);
-       return (&brd->br2684_devs != &br2684_devs) ? brd : NULL;
+       return seq_list_next(v, &br2684_devs, pos);
 }
 
 static void br2684_seq_stop(struct seq_file *seq, void *v)
+       __releases(devs_lock)
 {
        read_unlock(&devs_lock);
 }
 
 static int br2684_seq_show(struct seq_file *seq, void *v)
 {
-       const struct br2684_dev *brdev = v;
+       const struct br2684_dev *brdev = list_entry(v, struct br2684_dev,
+                                                   br2684_devs);
        const struct net_device *net_dev = brdev->net_dev;
        const struct br2684_vcc *brvcc;
 
-       seq_printf(seq, "dev %.16s: num=%d, mac=%02X:%02X:"
-                      "%02X:%02X:%02X:%02X (%s)\n", net_dev->name,
-                      brdev->number,
-                      net_dev->dev_addr[0],
-                      net_dev->dev_addr[1],
-                      net_dev->dev_addr[2],
-                      net_dev->dev_addr[3],
-                      net_dev->dev_addr[4],
-                      net_dev->dev_addr[5],
-                      brdev->mac_was_set ? "set" : "auto");
+       seq_printf(seq, "dev %.16s: num=%d, mac=%pM (%s)\n",
+                  net_dev->name,
+                  brdev->number,
+                  net_dev->dev_addr,
+                  brdev->mac_was_set ? "set" : "auto");
 
        list_for_each_entry(brvcc, &brdev->brvccs, brvccs) {
-               seq_printf(seq, "  vcc %d.%d.%d: encaps=%s"
-#ifndef FASTER_VERSION
-                                   ", failed copies %u/%u"
-#endif /* FASTER_VERSION */
-                                   "\n", brvcc->atmvcc->dev->number,
-                                   brvcc->atmvcc->vpi, brvcc->atmvcc->vci,
-                                   (brvcc->encaps == e_llc) ? "LLC" : "VC"
-#ifndef FASTER_VERSION
-                                   , brvcc->copies_failed
-                                   , brvcc->copies_needed
-#endif /* FASTER_VERSION */
-                                   );
+               seq_printf(seq, "  vcc %d.%d.%d: encaps=%s payload=%s"
+                          ", failed copies %u/%u"
+                          "\n", brvcc->atmvcc->dev->number,
+                          brvcc->atmvcc->vpi, brvcc->atmvcc->vci,
+                          (brvcc->encaps == e_llc) ? "LLC" : "VC",
+                          (brdev->payload == p_bridged) ? "bridged" : "routed",
+                          brvcc->copies_failed, brvcc->copies_needed);
 #ifdef CONFIG_ATM_BR2684_IPFILTER
 #define b1(var, byte)  ((u8 *) &brvcc->filter.var)[byte]
 #define bs(var)                b1(var, 0), b1(var, 1), b1(var, 2), b1(var, 3)
-                       if (brvcc->filter.netmask != 0)
-                               seq_printf(seq, "    filter=%d.%d.%d.%d/"
-                                               "%d.%d.%d.%d\n",
-                                               bs(prefix), bs(netmask));
+               if (brvcc->filter.netmask != 0)
+                       seq_printf(seq, "    filter=%d.%d.%d.%d/"
+                                  "%d.%d.%d.%d\n", bs(prefix), bs(netmask));
 #undef bs
 #undef b1
 #endif /* CONFIG_ATM_BR2684_IPFILTER */
@@ -755,11 +713,11 @@ static int br2684_seq_show(struct seq_file *seq, void *v)
        return 0;
 }
 
-static struct seq_operations br2684_seq_ops = {
+static const struct seq_operations br2684_seq_ops = {
        .start = br2684_seq_start,
-       .next  = br2684_seq_next,
-       .stop  = br2684_seq_stop,
-       .show  = br2684_seq_show,
+       .next = br2684_seq_next,
+       .stop = br2684_seq_stop,
+       .show = br2684_seq_show,
 };
 
 static int br2684_proc_open(struct inode *inode, struct file *file)
@@ -767,24 +725,24 @@ static int br2684_proc_open(struct inode *inode, struct file *file)
        return seq_open(file, &br2684_seq_ops);
 }
 
-static struct file_operations br2684_proc_ops = {
-       .owner   = THIS_MODULE,
-       .open    = br2684_proc_open,
-       .read    = seq_read,
-       .llseek  = seq_lseek,
+static const struct file_operations br2684_proc_ops = {
+       .owner = THIS_MODULE,
+       .open = br2684_proc_open,
+       .read = seq_read,
+       .llseek = seq_lseek,
        .release = seq_release,
 };
 
 extern struct proc_dir_entry *atm_proc_root;   /* from proc.c */
-#endif
+#endif /* CONFIG_PROC_FS */
 
 static int __init br2684_init(void)
 {
 #ifdef CONFIG_PROC_FS
        struct proc_dir_entry *p;
-       if ((p = create_proc_entry("br2684", 0, atm_proc_root)) == NULL)
+       p = proc_create("br2684", 0, atm_proc_root, &br2684_proc_ops);
+       if (p == NULL)
                return -ENOMEM;
-       p->proc_fops = &br2684_proc_ops;
 #endif
        register_atm_ioctl(&br2684_ioctl_ops);
        return 0;