Convert /proc/device-tree/ to seq_file
[safe/jmp/linux-2.6] / fs / proc / proc_devtree.c
index 67423c6..123257b 100644 (file)
  * Copyright 1997 Paul Mackerras
  */
 #include <linux/errno.h>
+#include <linux/init.h>
 #include <linux/time.h>
 #include <linux/proc_fs.h>
+#include <linux/seq_file.h>
 #include <linux/stat.h>
 #include <linux/string.h>
 #include <asm/prom.h>
 #include <asm/uaccess.h>
+#include "internal.h"
 
 #ifndef HAVE_ARCH_DEVTREE_FIXUPS
-static inline void set_node_proc_entry(struct device_node *np, struct proc_dir_entry *de)
+static inline void set_node_proc_entry(struct device_node *np,
+                                      struct proc_dir_entry *de)
 {
 }
+#endif
+
+static struct proc_dir_entry *proc_device_tree;
 
-static void inline set_node_name_link(struct device_node *np, struct proc_dir_entry *de)
+/*
+ * Supply data on a read from /proc/device-tree/node/property.
+ */
+static int property_proc_show(struct seq_file *m, void *v)
 {
+       struct property *pp = m->private;
+
+       seq_write(m, pp->value, pp->length);
+       return 0;
 }
 
-static void inline set_node_addr_link(struct device_node *np, struct proc_dir_entry *de)
+static int property_proc_open(struct inode *inode, struct file *file)
 {
+       return single_open(file, property_proc_show, PDE(inode)->data);
 }
-#endif
 
-static struct proc_dir_entry *proc_device_tree;
+static const struct file_operations property_proc_fops = {
+       .owner          = THIS_MODULE,
+       .open           = property_proc_open,
+       .read           = seq_read,
+       .llseek         = seq_lseek,
+       .release        = single_release,
+};
 
 /*
- * Supply data on a read from /proc/device-tree/node/property.
+ * For a node with a name like "gc@10", we make symlinks called "gc"
+ * and "@10" to it.
  */
-static int property_read_proc(char *page, char **start, off_t off,
-                             int count, int *eof, void *data)
+
+/*
+ * Add a property to a node
+ */
+static struct proc_dir_entry *
+__proc_device_tree_add_prop(struct proc_dir_entry *de, struct property *pp,
+               const char *name)
 {
-       struct property *pp = data;
-       int n;
+       struct proc_dir_entry *ent;
 
-       if (off >= pp->length) {
-               *eof = 1;
-               return 0;
-       }
-       n = pp->length - off;
-       if (n > count)
-               n = count;
+       /*
+        * Unfortunately proc_register puts each new entry
+        * at the beginning of the list.  So we rearrange them.
+        */
+       ent = proc_create_data(name,
+                              strncmp(name, "security-", 9) ? S_IRUGO : S_IRUSR,
+                              de, &property_proc_fops, pp);
+       if (ent == NULL)
+               return NULL;
+
+       if (!strncmp(name, "security-", 9))
+               ent->size = 0; /* don't leak number of password chars */
        else
-               *eof = 1;
-       memcpy(page, pp->value + off, n);
-       *start = page;
-       return n;
+               ent->size = pp->length;
+
+       return ent;
+}
+
+
+void proc_device_tree_add_prop(struct proc_dir_entry *pde, struct property *prop)
+{
+       __proc_device_tree_add_prop(pde, prop, prop->name);
+}
+
+void proc_device_tree_remove_prop(struct proc_dir_entry *pde,
+                                 struct property *prop)
+{
+       remove_proc_entry(prop->name, pde);
+}
+
+void proc_device_tree_update_prop(struct proc_dir_entry *pde,
+                                 struct property *newprop,
+                                 struct property *oldprop)
+{
+       struct proc_dir_entry *ent;
+
+       for (ent = pde->subdir; ent != NULL; ent = ent->next)
+               if (ent->data == oldprop)
+                       break;
+       if (ent == NULL) {
+               printk(KERN_WARNING "device-tree: property \"%s\" "
+                      " does not exist\n", oldprop->name);
+       } else {
+               ent->data = newprop;
+               ent->size = newprop->length;
+       }
 }
 
 /*
- * For a node with a name like "gc@10", we make symlinks called "gc"
- * and "@10" to it.
+ * Various dodgy firmware might give us nodes and/or properties with
+ * conflicting names. That's generally ok, except for exporting via /proc,
+ * so munge names here to ensure they're unique.
  */
 
+static int duplicate_name(struct proc_dir_entry *de, const char *name)
+{
+       struct proc_dir_entry *ent;
+       int found = 0;
+
+       spin_lock(&proc_subdir_lock);
+
+       for (ent = de->subdir; ent != NULL; ent = ent->next) {
+               if (strcmp(ent->name, name) == 0) {
+                       found = 1;
+                       break;
+               }
+       }
+
+       spin_unlock(&proc_subdir_lock);
+
+       return found;
+}
+
+static const char *fixup_name(struct device_node *np, struct proc_dir_entry *de,
+               const char *name)
+{
+       char *fixed_name;
+       int fixup_len = strlen(name) + 2 + 1; /* name + #x + \0 */
+       int i = 1, size;
+
+realloc:
+       fixed_name = kmalloc(fixup_len, GFP_KERNEL);
+       if (fixed_name == NULL) {
+               printk(KERN_ERR "device-tree: Out of memory trying to fixup "
+                               "name \"%s\"\n", name);
+               return name;
+       }
+
+retry:
+       size = snprintf(fixed_name, fixup_len, "%s#%d", name, i);
+       size++; /* account for NULL */
+
+       if (size > fixup_len) {
+               /* We ran out of space, free and reallocate. */
+               kfree(fixed_name);
+               fixup_len = size;
+               goto realloc;
+       }
+
+       if (duplicate_name(de, fixed_name)) {
+               /* Multiple duplicates. Retry with a different offset. */
+               i++;
+               goto retry;
+       }
+
+       printk(KERN_WARNING "device-tree: Duplicate name in %s, "
+                       "renamed to \"%s\"\n", np->full_name, fixed_name);
+
+       return fixed_name;
+}
+
 /*
  * Process a node, adding entries for its children and its properties.
  */
-void proc_device_tree_add_node(struct device_node *np, struct proc_dir_entry *de)
+void proc_device_tree_add_node(struct device_node *np,
+                              struct proc_dir_entry *de)
 {
        struct property *pp;
        struct proc_dir_entry *ent;
-       struct device_node *child, *sib;
-       const char *p, *at;
-       int l;
-       struct proc_dir_entry *list, **lastp, *al;
+       struct device_node *child;
+       const char *p;
 
        set_node_proc_entry(np, de);
-       lastp = &list;
-       for (pp = np->properties; pp != 0; pp = pp->next) {
-               /*
-                * Unfortunately proc_register puts each new entry
-                * at the beginning of the list.  So we rearrange them.
-                */
-               ent = create_proc_read_entry(pp->name, strncmp(pp->name, "security-", 9) ?
-                                            S_IRUGO : S_IRUSR, de, property_read_proc, pp);
-               if (ent == 0)
-                       break;
-               if (!strncmp(pp->name, "security-", 9))
-                    ent->size = 0; /* don't leak number of password chars */
-               else
-                    ent->size = pp->length;
-               *lastp = ent;
-               lastp = &ent->next;
-       }
-       child = NULL;
-       while ((child = of_get_next_child(np, child))) {
+       for (child = NULL; (child = of_get_next_child(np, child));) {
+               /* Use everything after the last slash, or the full name */
                p = strrchr(child->full_name, '/');
                if (!p)
                        p = child->full_name;
                else
                        ++p;
-               /* chop off '@0' if the name ends with that */
-               l = strlen(p);
-               if (l > 2 && p[l-2] == '@' && p[l-1] == '0')
-                       l -= 2;
+
+               if (duplicate_name(de, p))
+                       p = fixup_name(np, de, p);
+
                ent = proc_mkdir(p, de);
-               if (ent == 0)
+               if (ent == NULL)
                        break;
-               *lastp = ent;
-               lastp = &ent->next;
                proc_device_tree_add_node(child, ent);
+       }
+       of_node_put(child);
 
-               /*
-                * If we left the address part on the name, consider
-                * adding symlinks from the name and address parts.
-                */
-               if (p[l] != 0 || (at = strchr(p, '@')) == 0)
-                       continue;
-
-               /*
-                * If this is the first node with a given name property,
-                * add a symlink with the name property as its name.
-                */
-               sib = NULL;
-               while ((sib = of_get_next_child(np, sib)) && sib != child)
-                       if (sib->name && strcmp(sib->name, child->name) == 0)
-                               break;
-               if (sib == child && strncmp(p, child->name, l) != 0) {
-                       al = proc_symlink(child->name, de, ent->name);
-                       if (al == 0) {
-                               of_node_put(sib);
-                               break;
-                       }
-                       set_node_name_link(child, al);
-                       *lastp = al;
-                       lastp = &al->next;
-               }
-               of_node_put(sib);
-               /*
-                * Add another directory with the @address part as its name.
-                */
-               al = proc_symlink(at, de, ent->name);
-               if (al == 0)
+       for (pp = np->properties; pp != NULL; pp = pp->next) {
+               p = pp->name;
+
+               if (duplicate_name(de, p))
+                       p = fixup_name(np, de, p);
+
+               ent = __proc_device_tree_add_prop(de, pp, p);
+               if (ent == NULL)
                        break;
-               set_node_addr_link(child, al);
-               *lastp = al;
-               lastp = &al->next;
        }
-       of_node_put(child);
-       *lastp = NULL;
-       de->subdir = list;
 }
 
 /*
  * Called on initialization to set up the /proc/device-tree subtree
  */
-void proc_device_tree_init(void)
+void __init proc_device_tree_init(void)
 {
        struct device_node *root;
-       if ( !have_of )
-               return;
+
        proc_device_tree = proc_mkdir("device-tree", NULL);
-       if (proc_device_tree == 0)
+       if (proc_device_tree == NULL)
                return;
        root = of_find_node_by_path("/");
-       if (root == 0) {
+       if (root == NULL) {
                printk(KERN_ERR "/proc/device-tree: can't find root\n");
                return;
        }