tunnels: fix netns vs proto registration ordering
[safe/jmp/linux-2.6] / fs / ocfs2 / quota_local.c
index 55c3f2f..21f9e71 100644 (file)
@@ -20,6 +20,7 @@
 #include "sysfile.h"
 #include "dlmglue.h"
 #include "quota.h"
+#include "uptodate.h"
 
 /* Number of local quota structures per block */
 static inline unsigned int ol_quota_entries_per_block(struct super_block *sb)
@@ -49,14 +50,25 @@ static unsigned int ol_quota_chunk_block(struct super_block *sb, int c)
        return 1 + (ol_chunk_blocks(sb) + 1) * c;
 }
 
-/* Offset of the dquot structure in the quota file */
-static loff_t ol_dqblk_off(struct super_block *sb, int c, int off)
+static unsigned int ol_dqblk_block(struct super_block *sb, int c, int off)
 {
        int epb = ol_quota_entries_per_block(sb);
 
-       return ((ol_quota_chunk_block(sb, c) + 1 + off / epb)
-               << sb->s_blocksize_bits) +
-               (off % epb) * sizeof(struct ocfs2_local_disk_dqblk);
+       return ol_quota_chunk_block(sb, c) + 1 + off / epb;
+}
+
+static unsigned int ol_dqblk_block_off(struct super_block *sb, int c, int off)
+{
+       int epb = ol_quota_entries_per_block(sb);
+
+       return (off % epb) * sizeof(struct ocfs2_local_disk_dqblk);
+}
+
+/* Offset of the dquot structure in the quota file */
+static loff_t ol_dqblk_off(struct super_block *sb, int c, int off)
+{
+       return (ol_dqblk_block(sb, c, off) << sb->s_blocksize_bits) +
+              ol_dqblk_block_off(sb, c, off);
 }
 
 /* Compute block number from given offset */
@@ -89,14 +101,15 @@ static int ocfs2_modify_bh(struct inode *inode, struct buffer_head *bh,
        handle_t *handle;
        int status;
 
-       handle = ocfs2_start_trans(OCFS2_SB(sb), 1);
+       handle = ocfs2_start_trans(OCFS2_SB(sb),
+                                  OCFS2_QUOTA_BLOCK_UPDATE_CREDITS);
        if (IS_ERR(handle)) {
                status = PTR_ERR(handle);
                mlog_errno(status);
                return status;
        }
-       status = ocfs2_journal_access(handle, inode, bh,
-                                     OCFS2_JOURNAL_ACCESS_WRITE);
+       status = ocfs2_journal_access_dq(handle, INODE_CACHE(inode), bh,
+                                        OCFS2_JOURNAL_ACCESS_WRITE);
        if (status < 0) {
                mlog_errno(status);
                ocfs2_commit_trans(OCFS2_SB(sb), handle);
@@ -128,15 +141,15 @@ static int ocfs2_local_check_quota_file(struct super_block *sb, int type)
        unsigned int gversions[MAXQUOTAS] = OCFS2_GLOBAL_QVERSIONS;
        unsigned int ino[MAXQUOTAS] = { USER_QUOTA_SYSTEM_INODE,
                                        GROUP_QUOTA_SYSTEM_INODE };
-       struct buffer_head *bh;
+       struct buffer_head *bh = NULL;
        struct inode *linode = sb_dqopt(sb)->files[type];
        struct inode *ginode = NULL;
        struct ocfs2_disk_dqheader *dqhead;
        int status, ret = 0;
 
        /* First check whether we understand local quota file */
-       bh = ocfs2_read_quota_block(linode, 0, &status);
-       if (!bh) {
+       status = ocfs2_read_quota_block(linode, 0, &bh);
+       if (status) {
                mlog_errno(status);
                mlog(ML_ERROR, "failed to read quota file header (type=%d)\n",
                        type);
@@ -167,8 +180,8 @@ static int ocfs2_local_check_quota_file(struct super_block *sb, int type)
                goto out_err;
        }
        /* Since the header is read only, we don't care about locking */
-       bh = ocfs2_read_quota_block(ginode, 0, &status);
-       if (!bh) {
+       status = ocfs2_read_quota_block(ginode, 0, &bh);
+       if (status) {
                mlog_errno(status);
                mlog(ML_ERROR, "failed to read global quota file header "
                                "(type=%d)\n", type);
@@ -224,10 +237,11 @@ static int ocfs2_load_local_quota_bitmaps(struct inode *inode,
                        return -ENOMEM;
                }
                newchunk->qc_num = i;
-               newchunk->qc_headerbh = ocfs2_read_quota_block(inode,
+               newchunk->qc_headerbh = NULL;
+               status = ocfs2_read_quota_block(inode,
                                ol_quota_chunk_block(inode->i_sb, i),
-                               &status);
-               if (!newchunk->qc_headerbh) {
+                               &newchunk->qc_headerbh);
+               if (status) {
                        mlog_errno(status);
                        kmem_cache_free(ocfs2_qf_chunk_cachep, newchunk);
                        ocfs2_release_local_quota_bitmaps(head);
@@ -253,6 +267,389 @@ static void olq_update_info(struct buffer_head *bh, void *private)
        spin_unlock(&dq_data_lock);
 }
 
+static int ocfs2_add_recovery_chunk(struct super_block *sb,
+                                   struct ocfs2_local_disk_chunk *dchunk,
+                                   int chunk,
+                                   struct list_head *head)
+{
+       struct ocfs2_recovery_chunk *rc;
+
+       rc = kmalloc(sizeof(struct ocfs2_recovery_chunk), GFP_NOFS);
+       if (!rc)
+               return -ENOMEM;
+       rc->rc_chunk = chunk;
+       rc->rc_bitmap = kmalloc(sb->s_blocksize, GFP_NOFS);
+       if (!rc->rc_bitmap) {
+               kfree(rc);
+               return -ENOMEM;
+       }
+       memcpy(rc->rc_bitmap, dchunk->dqc_bitmap,
+              (ol_chunk_entries(sb) + 7) >> 3);
+       list_add_tail(&rc->rc_list, head);
+       return 0;
+}
+
+static void free_recovery_list(struct list_head *head)
+{
+       struct ocfs2_recovery_chunk *next;
+       struct ocfs2_recovery_chunk *rchunk;
+
+       list_for_each_entry_safe(rchunk, next, head, rc_list) {
+               list_del(&rchunk->rc_list);
+               kfree(rchunk->rc_bitmap);
+               kfree(rchunk);
+       }
+}
+
+void ocfs2_free_quota_recovery(struct ocfs2_quota_recovery *rec)
+{
+       int type;
+
+       for (type = 0; type < MAXQUOTAS; type++)
+               free_recovery_list(&(rec->r_list[type]));
+       kfree(rec);
+}
+
+/* Load entries in our quota file we have to recover*/
+static int ocfs2_recovery_load_quota(struct inode *lqinode,
+                                    struct ocfs2_local_disk_dqinfo *ldinfo,
+                                    int type,
+                                    struct list_head *head)
+{
+       struct super_block *sb = lqinode->i_sb;
+       struct buffer_head *hbh;
+       struct ocfs2_local_disk_chunk *dchunk;
+       int i, chunks = le32_to_cpu(ldinfo->dqi_chunks);
+       int status = 0;
+
+       for (i = 0; i < chunks; i++) {
+               hbh = NULL;
+               status = ocfs2_read_quota_block(lqinode,
+                                               ol_quota_chunk_block(sb, i),
+                                               &hbh);
+               if (status) {
+                       mlog_errno(status);
+                       break;
+               }
+               dchunk = (struct ocfs2_local_disk_chunk *)hbh->b_data;
+               if (le32_to_cpu(dchunk->dqc_free) < ol_chunk_entries(sb))
+                       status = ocfs2_add_recovery_chunk(sb, dchunk, i, head);
+               brelse(hbh);
+               if (status < 0)
+                       break;
+       }
+       if (status < 0)
+               free_recovery_list(head);
+       return status;
+}
+
+static struct ocfs2_quota_recovery *ocfs2_alloc_quota_recovery(void)
+{
+       int type;
+       struct ocfs2_quota_recovery *rec;
+
+       rec = kmalloc(sizeof(struct ocfs2_quota_recovery), GFP_NOFS);
+       if (!rec)
+               return NULL;
+       for (type = 0; type < MAXQUOTAS; type++)
+               INIT_LIST_HEAD(&(rec->r_list[type]));
+       return rec;
+}
+
+/* Load information we need for quota recovery into memory */
+struct ocfs2_quota_recovery *ocfs2_begin_quota_recovery(
+                                               struct ocfs2_super *osb,
+                                               int slot_num)
+{
+       unsigned int feature[MAXQUOTAS] = { OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
+                                           OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
+       unsigned int ino[MAXQUOTAS] = { LOCAL_USER_QUOTA_SYSTEM_INODE,
+                                       LOCAL_GROUP_QUOTA_SYSTEM_INODE };
+       struct super_block *sb = osb->sb;
+       struct ocfs2_local_disk_dqinfo *ldinfo;
+       struct inode *lqinode;
+       struct buffer_head *bh;
+       int type;
+       int status = 0;
+       struct ocfs2_quota_recovery *rec;
+
+       mlog(ML_NOTICE, "Beginning quota recovery in slot %u\n", slot_num);
+       rec = ocfs2_alloc_quota_recovery();
+       if (!rec)
+               return ERR_PTR(-ENOMEM);
+       /* First init... */
+
+       for (type = 0; type < MAXQUOTAS; type++) {
+               if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
+                       continue;
+               /* At this point, journal of the slot is already replayed so
+                * we can trust metadata and data of the quota file */
+               lqinode = ocfs2_get_system_file_inode(osb, ino[type], slot_num);
+               if (!lqinode) {
+                       status = -ENOENT;
+                       goto out;
+               }
+               status = ocfs2_inode_lock_full(lqinode, NULL, 1,
+                                              OCFS2_META_LOCK_RECOVERY);
+               if (status < 0) {
+                       mlog_errno(status);
+                       goto out_put;
+               }
+               /* Now read local header */
+               bh = NULL;
+               status = ocfs2_read_quota_block(lqinode, 0, &bh);
+               if (status) {
+                       mlog_errno(status);
+                       mlog(ML_ERROR, "failed to read quota file info header "
+                               "(slot=%d type=%d)\n", slot_num, type);
+                       goto out_lock;
+               }
+               ldinfo = (struct ocfs2_local_disk_dqinfo *)(bh->b_data +
+                                                       OCFS2_LOCAL_INFO_OFF);
+               status = ocfs2_recovery_load_quota(lqinode, ldinfo, type,
+                                                  &rec->r_list[type]);
+               brelse(bh);
+out_lock:
+               ocfs2_inode_unlock(lqinode, 1);
+out_put:
+               iput(lqinode);
+               if (status < 0)
+                       break;
+       }
+out:
+       if (status < 0) {
+               ocfs2_free_quota_recovery(rec);
+               rec = ERR_PTR(status);
+       }
+       return rec;
+}
+
+/* Sync changes in local quota file into global quota file and
+ * reinitialize local quota file.
+ * The function expects local quota file to be already locked and
+ * dqonoff_mutex locked. */
+static int ocfs2_recover_local_quota_file(struct inode *lqinode,
+                                         int type,
+                                         struct ocfs2_quota_recovery *rec)
+{
+       struct super_block *sb = lqinode->i_sb;
+       struct ocfs2_mem_dqinfo *oinfo = sb_dqinfo(sb, type)->dqi_priv;
+       struct ocfs2_local_disk_chunk *dchunk;
+       struct ocfs2_local_disk_dqblk *dqblk;
+       struct dquot *dquot;
+       handle_t *handle;
+       struct buffer_head *hbh = NULL, *qbh = NULL;
+       int status = 0;
+       int bit, chunk;
+       struct ocfs2_recovery_chunk *rchunk, *next;
+       qsize_t spacechange, inodechange;
+
+       mlog_entry("ino=%lu type=%u", (unsigned long)lqinode->i_ino, type);
+
+       list_for_each_entry_safe(rchunk, next, &(rec->r_list[type]), rc_list) {
+               chunk = rchunk->rc_chunk;
+               hbh = NULL;
+               status = ocfs2_read_quota_block(lqinode,
+                                               ol_quota_chunk_block(sb, chunk),
+                                               &hbh);
+               if (status) {
+                       mlog_errno(status);
+                       break;
+               }
+               dchunk = (struct ocfs2_local_disk_chunk *)hbh->b_data;
+               for_each_bit(bit, rchunk->rc_bitmap, ol_chunk_entries(sb)) {
+                       qbh = NULL;
+                       status = ocfs2_read_quota_block(lqinode,
+                                               ol_dqblk_block(sb, chunk, bit),
+                                               &qbh);
+                       if (status) {
+                               mlog_errno(status);
+                               break;
+                       }
+                       dqblk = (struct ocfs2_local_disk_dqblk *)(qbh->b_data +
+                               ol_dqblk_block_off(sb, chunk, bit));
+                       dquot = dqget(sb, le64_to_cpu(dqblk->dqb_id), type);
+                       if (!dquot) {
+                               status = -EIO;
+                               mlog(ML_ERROR, "Failed to get quota structure "
+                                    "for id %u, type %d. Cannot finish quota "
+                                    "file recovery.\n",
+                                    (unsigned)le64_to_cpu(dqblk->dqb_id),
+                                    type);
+                               goto out_put_bh;
+                       }
+                       status = ocfs2_lock_global_qf(oinfo, 1);
+                       if (status < 0) {
+                               mlog_errno(status);
+                               goto out_put_dquot;
+                       }
+
+                       handle = ocfs2_start_trans(OCFS2_SB(sb),
+                                                  OCFS2_QSYNC_CREDITS);
+                       if (IS_ERR(handle)) {
+                               status = PTR_ERR(handle);
+                               mlog_errno(status);
+                               goto out_drop_lock;
+                       }
+                       mutex_lock(&sb_dqopt(sb)->dqio_mutex);
+                       spin_lock(&dq_data_lock);
+                       /* Add usage from quota entry into quota changes
+                        * of our node. Auxiliary variables are important
+                        * due to signedness */
+                       spacechange = le64_to_cpu(dqblk->dqb_spacemod);
+                       inodechange = le64_to_cpu(dqblk->dqb_inodemod);
+                       dquot->dq_dqb.dqb_curspace += spacechange;
+                       dquot->dq_dqb.dqb_curinodes += inodechange;
+                       spin_unlock(&dq_data_lock);
+                       /* We want to drop reference held by the crashed
+                        * node. Since we have our own reference we know
+                        * global structure actually won't be freed. */
+                       status = ocfs2_global_release_dquot(dquot);
+                       if (status < 0) {
+                               mlog_errno(status);
+                               goto out_commit;
+                       }
+                       /* Release local quota file entry */
+                       status = ocfs2_journal_access_dq(handle,
+                                       INODE_CACHE(lqinode),
+                                       qbh, OCFS2_JOURNAL_ACCESS_WRITE);
+                       if (status < 0) {
+                               mlog_errno(status);
+                               goto out_commit;
+                       }
+                       lock_buffer(qbh);
+                       WARN_ON(!ocfs2_test_bit(bit, dchunk->dqc_bitmap));
+                       ocfs2_clear_bit(bit, dchunk->dqc_bitmap);
+                       le32_add_cpu(&dchunk->dqc_free, 1);
+                       unlock_buffer(qbh);
+                       status = ocfs2_journal_dirty(handle, qbh);
+                       if (status < 0)
+                               mlog_errno(status);
+out_commit:
+                       mutex_unlock(&sb_dqopt(sb)->dqio_mutex);
+                       ocfs2_commit_trans(OCFS2_SB(sb), handle);
+out_drop_lock:
+                       ocfs2_unlock_global_qf(oinfo, 1);
+out_put_dquot:
+                       dqput(dquot);
+out_put_bh:
+                       brelse(qbh);
+                       if (status < 0)
+                               break;
+               }
+               brelse(hbh);
+               list_del(&rchunk->rc_list);
+               kfree(rchunk->rc_bitmap);
+               kfree(rchunk);
+               if (status < 0)
+                       break;
+       }
+       if (status < 0)
+               free_recovery_list(&(rec->r_list[type]));
+       mlog_exit(status);
+       return status;
+}
+
+/* Recover local quota files for given node different from us */
+int ocfs2_finish_quota_recovery(struct ocfs2_super *osb,
+                               struct ocfs2_quota_recovery *rec,
+                               int slot_num)
+{
+       unsigned int ino[MAXQUOTAS] = { LOCAL_USER_QUOTA_SYSTEM_INODE,
+                                       LOCAL_GROUP_QUOTA_SYSTEM_INODE };
+       struct super_block *sb = osb->sb;
+       struct ocfs2_local_disk_dqinfo *ldinfo;
+       struct buffer_head *bh;
+       handle_t *handle;
+       int type;
+       int status = 0;
+       struct inode *lqinode;
+       unsigned int flags;
+
+       mlog(ML_NOTICE, "Finishing quota recovery in slot %u\n", slot_num);
+       mutex_lock(&sb_dqopt(sb)->dqonoff_mutex);
+       for (type = 0; type < MAXQUOTAS; type++) {
+               if (list_empty(&(rec->r_list[type])))
+                       continue;
+               mlog(0, "Recovering quota in slot %d\n", slot_num);
+               lqinode = ocfs2_get_system_file_inode(osb, ino[type], slot_num);
+               if (!lqinode) {
+                       status = -ENOENT;
+                       goto out;
+               }
+               status = ocfs2_inode_lock_full(lqinode, NULL, 1,
+                                                      OCFS2_META_LOCK_NOQUEUE);
+               /* Someone else is holding the lock? Then he must be
+                * doing the recovery. Just skip the file... */
+               if (status == -EAGAIN) {
+                       mlog(ML_NOTICE, "skipping quota recovery for slot %d "
+                            "because quota file is locked.\n", slot_num);
+                       status = 0;
+                       goto out_put;
+               } else if (status < 0) {
+                       mlog_errno(status);
+                       goto out_put;
+               }
+               /* Now read local header */
+               bh = NULL;
+               status = ocfs2_read_quota_block(lqinode, 0, &bh);
+               if (status) {
+                       mlog_errno(status);
+                       mlog(ML_ERROR, "failed to read quota file info header "
+                               "(slot=%d type=%d)\n", slot_num, type);
+                       goto out_lock;
+               }
+               ldinfo = (struct ocfs2_local_disk_dqinfo *)(bh->b_data +
+                                                       OCFS2_LOCAL_INFO_OFF);
+               /* Is recovery still needed? */
+               flags = le32_to_cpu(ldinfo->dqi_flags);
+               if (!(flags & OLQF_CLEAN))
+                       status = ocfs2_recover_local_quota_file(lqinode,
+                                                               type,
+                                                               rec);
+               /* We don't want to mark file as clean when it is actually
+                * active */
+               if (slot_num == osb->slot_num)
+                       goto out_bh;
+               /* Mark quota file as clean if we are recovering quota file of
+                * some other node. */
+               handle = ocfs2_start_trans(osb,
+                                          OCFS2_LOCAL_QINFO_WRITE_CREDITS);
+               if (IS_ERR(handle)) {
+                       status = PTR_ERR(handle);
+                       mlog_errno(status);
+                       goto out_bh;
+               }
+               status = ocfs2_journal_access_dq(handle, INODE_CACHE(lqinode),
+                                                bh,
+                                                OCFS2_JOURNAL_ACCESS_WRITE);
+               if (status < 0) {
+                       mlog_errno(status);
+                       goto out_trans;
+               }
+               lock_buffer(bh);
+               ldinfo->dqi_flags = cpu_to_le32(flags | OLQF_CLEAN);
+               unlock_buffer(bh);
+               status = ocfs2_journal_dirty(handle, bh);
+               if (status < 0)
+                       mlog_errno(status);
+out_trans:
+               ocfs2_commit_trans(osb, handle);
+out_bh:
+               brelse(bh);
+out_lock:
+               ocfs2_inode_unlock(lqinode, 1);
+out_put:
+               iput(lqinode);
+               if (status < 0)
+                       break;
+       }
+out:
+       mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex);
+       kfree(rec);
+       return status;
+}
+
 /* Read information header from quota file */
 static int ocfs2_local_read_info(struct super_block *sb, int type)
 {
@@ -262,8 +659,12 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
        struct inode *lqinode = sb_dqopt(sb)->files[type];
        int status;
        struct buffer_head *bh = NULL;
+       struct ocfs2_quota_recovery *rec;
        int locked = 0;
 
+       /* We don't need the lock and we have to acquire quota file locks
+        * which will later depend on this lock */
+       mutex_unlock(&sb_dqopt(sb)->dqio_mutex);
        info->dqi_maxblimit = 0x7fffffffffffffffLL;
        info->dqi_maxilimit = 0x7fffffffffffffffLL;
        oinfo = kmalloc(sizeof(struct ocfs2_mem_dqinfo), GFP_NOFS);
@@ -275,6 +676,7 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
        info->dqi_priv = oinfo;
        oinfo->dqi_type = type;
        INIT_LIST_HEAD(&oinfo->dqi_chunk);
+       oinfo->dqi_rec = NULL;
        oinfo->dqi_lqi_bh = NULL;
        oinfo->dqi_ibh = NULL;
 
@@ -290,8 +692,8 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
        locked = 1;
 
        /* Now read local header */
-       bh = ocfs2_read_quota_block(lqinode, 0, &status);
-       if (!bh) {
+       status = ocfs2_read_quota_block(lqinode, 0, &bh);
+       if (status) {
                mlog_errno(status);
                mlog(ML_ERROR, "failed to read quota file info header "
                        "(type=%d)\n", type);
@@ -305,10 +707,27 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
        oinfo->dqi_ibh = bh;
 
        /* We crashed when using local quota file? */
-       if (!(info->dqi_flags & OLQF_CLEAN))
-               goto out_err;   /* So far we just bail out. Later we should resync here */
+       if (!(info->dqi_flags & OLQF_CLEAN)) {
+               rec = OCFS2_SB(sb)->quota_rec;
+               if (!rec) {
+                       rec = ocfs2_alloc_quota_recovery();
+                       if (!rec) {
+                               status = -ENOMEM;
+                               mlog_errno(status);
+                               goto out_err;
+                       }
+                       OCFS2_SB(sb)->quota_rec = rec;
+               }
+
+               status = ocfs2_recovery_load_quota(lqinode, ldinfo, type,
+                                                   &rec->r_list[type]);
+               if (status < 0) {
+                       mlog_errno(status);
+                       goto out_err;
+               }
+       }
 
-       status = ocfs2_load_local_quota_bitmaps(sb_dqopt(sb)->files[type],
+       status = ocfs2_load_local_quota_bitmaps(lqinode,
                                                ldinfo,
                                                &oinfo->dqi_chunk);
        if (status < 0) {
@@ -324,6 +743,7 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
                goto out_err;
        }
 
+       mutex_lock(&sb_dqopt(sb)->dqio_mutex);
        return 0;
 out_err:
        if (oinfo) {
@@ -337,6 +757,7 @@ out_err:
                kfree(oinfo);
        }
        brelse(bh);
+       mutex_lock(&sb_dqopt(sb)->dqio_mutex);
        return -1;
 }
 
@@ -368,6 +789,10 @@ static int ocfs2_local_free_info(struct super_block *sb, int type)
        int mark_clean = 1, len;
        int status;
 
+       /* At this point we know there are no more dquots and thus
+        * even if there's some sync in the pdflush queue, it won't
+        * find any dquots and return without doing anything */
+       cancel_delayed_work_sync(&oinfo->dqi_sync_work);
        iput(oinfo->dqi_gqinode);
        ocfs2_simple_drop_lockres(OCFS2_SB(sb), &oinfo->dqi_gqlock);
        ocfs2_lock_res_free(&oinfo->dqi_gqlock);
@@ -390,6 +815,12 @@ static int ocfs2_local_free_info(struct super_block *sb, int type)
        }
        ocfs2_release_local_quota_bitmaps(&oinfo->dqi_chunk);
 
+       /* dqonoff_mutex protects us against racing with recovery thread... */
+       if (oinfo->dqi_rec) {
+               ocfs2_free_quota_recovery(oinfo->dqi_rec);
+               mark_clean = 0;
+       }
+
        if (!mark_clean)
                goto out;
 
@@ -429,7 +860,8 @@ static void olq_set_dquot(struct buffer_head *bh, void *private)
                                          od->dq_originodes);
        spin_unlock(&dq_data_lock);
        mlog(0, "Writing local dquot %u space %lld inodes %lld\n",
-            od->dq_dquot.dq_id, dqblk->dqb_spacemod, dqblk->dqb_inodemod);
+            od->dq_dquot.dq_id, (long long)le64_to_cpu(dqblk->dqb_spacemod),
+            (long long)le64_to_cpu(dqblk->dqb_inodemod));
 }
 
 /* Write dquot to local quota file */
@@ -437,13 +869,13 @@ static int ocfs2_local_write_dquot(struct dquot *dquot)
 {
        struct super_block *sb = dquot->dq_sb;
        struct ocfs2_dquot *od = OCFS2_DQUOT(dquot);
-       struct buffer_head *bh;
+       struct buffer_head *bh = NULL;
        int status;
 
-       bh = ocfs2_read_quota_block(sb_dqopt(sb)->files[dquot->dq_type],
+       status = ocfs2_read_quota_block(sb_dqopt(sb)->files[dquot->dq_type],
                                    ol_dqblk_file_block(sb, od->dq_local_off),
-                                   &status);
-       if (!bh) {
+                                   &bh);
+       if (status) {
                mlog_errno(status);
                goto out;
        }
@@ -513,7 +945,7 @@ static struct ocfs2_quota_chunk *ocfs2_local_quota_add_chunk(
        struct ocfs2_local_disk_chunk *dchunk;
        int status;
        handle_t *handle;
-       struct buffer_head *bh = NULL;
+       struct buffer_head *bh = NULL, *dbh = NULL;
        u64 p_blkno;
 
        /* We are protected by dqio_sem so no locking needed */
@@ -537,42 +969,44 @@ static struct ocfs2_quota_chunk *ocfs2_local_quota_add_chunk(
                mlog_errno(status);
                goto out;
        }
+       /* Local quota info and two new blocks we initialize */
+       handle = ocfs2_start_trans(OCFS2_SB(sb),
+                       OCFS2_LOCAL_QINFO_WRITE_CREDITS +
+                       2 * OCFS2_QUOTA_BLOCK_UPDATE_CREDITS);
+       if (IS_ERR(handle)) {
+               status = PTR_ERR(handle);
+               mlog_errno(status);
+               goto out;
+       }
 
+       /* Initialize chunk header */
        down_read(&OCFS2_I(lqinode)->ip_alloc_sem);
        status = ocfs2_extent_map_get_blocks(lqinode, oinfo->dqi_blocks,
                                             &p_blkno, NULL, NULL);
        up_read(&OCFS2_I(lqinode)->ip_alloc_sem);
        if (status < 0) {
                mlog_errno(status);
-               goto out;
+               goto out_trans;
        }
        bh = sb_getblk(sb, p_blkno);
        if (!bh) {
                status = -ENOMEM;
                mlog_errno(status);
-               goto out;
+               goto out_trans;
        }
        dchunk = (struct ocfs2_local_disk_chunk *)bh->b_data;
-
-       handle = ocfs2_start_trans(OCFS2_SB(sb), 2);
-       if (IS_ERR(handle)) {
-               status = PTR_ERR(handle);
-               mlog_errno(status);
-               goto out;
-       }
-
-       status = ocfs2_journal_access(handle, lqinode, bh,
-                                     OCFS2_JOURNAL_ACCESS_WRITE);
+       ocfs2_set_new_buffer_uptodate(INODE_CACHE(lqinode), bh);
+       status = ocfs2_journal_access_dq(handle, INODE_CACHE(lqinode), bh,
+                                        OCFS2_JOURNAL_ACCESS_CREATE);
        if (status < 0) {
                mlog_errno(status);
                goto out_trans;
        }
        lock_buffer(bh);
-       dchunk->dqc_free = ol_quota_entries_per_block(sb);
+       dchunk->dqc_free = cpu_to_le32(ol_quota_entries_per_block(sb));
        memset(dchunk->dqc_bitmap, 0,
               sb->s_blocksize - sizeof(struct ocfs2_local_disk_chunk) -
               OCFS2_QBLK_RESERVED_SPACE);
-       set_buffer_uptodate(bh);
        unlock_buffer(bh);
        status = ocfs2_journal_dirty(handle, bh);
        if (status < 0) {
@@ -580,6 +1014,38 @@ static struct ocfs2_quota_chunk *ocfs2_local_quota_add_chunk(
                goto out_trans;
        }
 
+       /* Initialize new block with structures */
+       down_read(&OCFS2_I(lqinode)->ip_alloc_sem);
+       status = ocfs2_extent_map_get_blocks(lqinode, oinfo->dqi_blocks + 1,
+                                            &p_blkno, NULL, NULL);
+       up_read(&OCFS2_I(lqinode)->ip_alloc_sem);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out_trans;
+       }
+       dbh = sb_getblk(sb, p_blkno);
+       if (!dbh) {
+               status = -ENOMEM;
+               mlog_errno(status);
+               goto out_trans;
+       }
+       ocfs2_set_new_buffer_uptodate(INODE_CACHE(lqinode), dbh);
+       status = ocfs2_journal_access_dq(handle, INODE_CACHE(lqinode), dbh,
+                                        OCFS2_JOURNAL_ACCESS_CREATE);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out_trans;
+       }
+       lock_buffer(dbh);
+       memset(dbh->b_data, 0, sb->s_blocksize - OCFS2_QBLK_RESERVED_SPACE);
+       unlock_buffer(dbh);
+       status = ocfs2_journal_dirty(handle, dbh);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out_trans;
+       }
+
+       /* Update local quotafile info */
        oinfo->dqi_blocks += 2;
        oinfo->dqi_chunks++;
        status = ocfs2_local_write_info(sb, type);
@@ -604,6 +1070,7 @@ out_trans:
        ocfs2_commit_trans(OCFS2_SB(sb), handle);
 out:
        brelse(bh);
+       brelse(dbh);
        kmem_cache_free(ocfs2_qf_chunk_cachep, chunk);
        return ERR_PTR(status);
 }
@@ -621,6 +1088,8 @@ static struct ocfs2_quota_chunk *ocfs2_extend_local_quota_file(
        struct ocfs2_local_disk_chunk *dchunk;
        int epb = ol_quota_entries_per_block(sb);
        unsigned int chunk_blocks;
+       struct buffer_head *bh;
+       u64 p_blkno;
        int status;
        handle_t *handle;
 
@@ -648,13 +1117,51 @@ static struct ocfs2_quota_chunk *ocfs2_extend_local_quota_file(
                mlog_errno(status);
                goto out;
        }
-       handle = ocfs2_start_trans(OCFS2_SB(sb), 2);
+
+       /* Get buffer from the just added block */
+       down_read(&OCFS2_I(lqinode)->ip_alloc_sem);
+       status = ocfs2_extent_map_get_blocks(lqinode, oinfo->dqi_blocks,
+                                            &p_blkno, NULL, NULL);
+       up_read(&OCFS2_I(lqinode)->ip_alloc_sem);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out;
+       }
+       bh = sb_getblk(sb, p_blkno);
+       if (!bh) {
+               status = -ENOMEM;
+               mlog_errno(status);
+               goto out;
+       }
+       ocfs2_set_new_buffer_uptodate(INODE_CACHE(lqinode), bh);
+
+       /* Local quota info, chunk header and the new block we initialize */
+       handle = ocfs2_start_trans(OCFS2_SB(sb),
+                       OCFS2_LOCAL_QINFO_WRITE_CREDITS +
+                       2 * OCFS2_QUOTA_BLOCK_UPDATE_CREDITS);
        if (IS_ERR(handle)) {
                status = PTR_ERR(handle);
                mlog_errno(status);
                goto out;
        }
-       status = ocfs2_journal_access(handle, lqinode, chunk->qc_headerbh,
+       /* Zero created block */
+       status = ocfs2_journal_access_dq(handle, INODE_CACHE(lqinode), bh,
+                                OCFS2_JOURNAL_ACCESS_CREATE);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out_trans;
+       }
+       lock_buffer(bh);
+       memset(bh->b_data, 0, sb->s_blocksize);
+       unlock_buffer(bh);
+       status = ocfs2_journal_dirty(handle, bh);
+       if (status < 0) {
+               mlog_errno(status);
+               goto out_trans;
+       }
+       /* Update chunk header */
+       status = ocfs2_journal_access_dq(handle, INODE_CACHE(lqinode),
+                                        chunk->qc_headerbh,
                                 OCFS2_JOURNAL_ACCESS_WRITE);
        if (status < 0) {
                mlog_errno(status);
@@ -670,6 +1177,7 @@ static struct ocfs2_quota_chunk *ocfs2_extend_local_quota_file(
                mlog_errno(status);
                goto out_trans;
        }
+       /* Update file header */
        oinfo->dqi_blocks++;
        status = ocfs2_local_write_info(sb, type);
        if (status < 0) {
@@ -690,7 +1198,7 @@ out:
        return ERR_PTR(status);
 }
 
-void olq_alloc_dquot(struct buffer_head *bh, void *private)
+static void olq_alloc_dquot(struct buffer_head *bh, void *private)
 {
        int *offset = private;
        struct ocfs2_local_disk_chunk *dchunk;
@@ -787,7 +1295,8 @@ static int ocfs2_local_release_dquot(struct dquot *dquot)
                goto out;
        }
 
-       status = ocfs2_journal_access(handle, sb_dqopt(sb)->files[type],
+       status = ocfs2_journal_access_dq(handle,
+                       INODE_CACHE(sb_dqopt(sb)->files[type]),
                        od->dq_chunk->qc_headerbh, OCFS2_JOURNAL_ACCESS_WRITE);
        if (status < 0) {
                mlog_errno(status);
@@ -816,7 +1325,7 @@ out:
        return status;
 }
 
-static struct quota_format_ops ocfs2_format_ops = {
+static const struct quota_format_ops ocfs2_format_ops = {
        .check_quota_file       = ocfs2_local_check_quota_file,
        .read_file_info         = ocfs2_local_read_info,
        .write_file_info        = ocfs2_global_write_info,