nfs: Fix misparsing of nfsv4 fs_locations attribute
[safe/jmp/linux-2.6] / fs / nfs / nfs4namespace.c
index faed9bc..30befc3 100644 (file)
@@ -2,12 +2,11 @@
  * linux/fs/nfs/nfs4namespace.c
  *
  * Copyright (C) 2005 Trond Myklebust <Trond.Myklebust@netapp.com>
+ * - Modified by David Howells <dhowells@redhat.com>
  *
  * NFSv4 namespace
  */
 
-#include <linux/config.h>
-
 #include <linux/dcache.h>
 #include <linux/mount.h>
 #include <linux/namei.h>
@@ -17,6 +16,7 @@
 #include <linux/vfs.h>
 #include <linux/inet.h>
 #include "internal.h"
+#include "nfs4_fs.h"
 
 #define NFSDBG_FACILITY                NFSDBG_VFS
 
@@ -47,15 +47,105 @@ Elong:
        return ERR_PTR(-ENAMETOOLONG);
 }
 
+/*
+ * Determine the mount path as a string
+ */
+static char *nfs4_path(const struct vfsmount *mnt_parent,
+                      const struct dentry *dentry,
+                      char *buffer, ssize_t buflen)
+{
+       const char *srvpath;
+
+       srvpath = strchr(mnt_parent->mnt_devname, ':');
+       if (srvpath)
+               srvpath++;
+       else
+               srvpath = mnt_parent->mnt_devname;
+
+       return nfs_path(srvpath, mnt_parent->mnt_root, dentry, buffer, buflen);
+}
+
+/*
+ * Check that fs_locations::fs_root [RFC3530 6.3] is a prefix for what we
+ * believe to be the server path to this dentry
+ */
+static int nfs4_validate_fspath(const struct vfsmount *mnt_parent,
+                               const struct dentry *dentry,
+                               const struct nfs4_fs_locations *locations,
+                               char *page, char *page2)
+{
+       const char *path, *fs_path;
+
+       path = nfs4_path(mnt_parent, dentry, page, PAGE_SIZE);
+       if (IS_ERR(path))
+               return PTR_ERR(path);
+
+       fs_path = nfs4_pathname_string(&locations->fs_path, page2, PAGE_SIZE);
+       if (IS_ERR(fs_path))
+               return PTR_ERR(fs_path);
+
+       if (strncmp(path, fs_path, strlen(fs_path)) != 0) {
+               dprintk("%s: path %s does not begin with fsroot %s\n",
+                       __func__, path, fs_path);
+               return -ENOENT;
+       }
+
+       return 0;
+}
+
+static struct vfsmount *try_location(struct nfs_clone_mount *mountdata,
+                                    char *page, char *page2,
+                                    const struct nfs4_fs_location *location)
+{
+       struct vfsmount *mnt = ERR_PTR(-ENOENT);
+       char *mnt_path;
+       int page2len;
+       unsigned int s;
+
+       mnt_path = nfs4_pathname_string(&location->rootpath, page2, PAGE_SIZE);
+       if (IS_ERR(mnt_path))
+               return mnt;
+       mountdata->mnt_path = mnt_path;
+       page2 += strlen(mnt_path) + 1;
+       page2len = PAGE_SIZE - strlen(mnt_path) - 1;
+
+       for (s = 0; s < location->nservers; s++) {
+               const struct nfs4_string *buf = &location->servers[s];
+               struct sockaddr_storage addr;
+
+               if (buf->len <= 0 || buf->len >= PAGE_SIZE)
+                       continue;
+
+               mountdata->addr = (struct sockaddr *)&addr;
+
+               if (memchr(buf->data, IPV6_SCOPE_DELIMITER, buf->len))
+                       continue;
+               nfs_parse_ip_address(buf->data, buf->len,
+                               mountdata->addr, &mountdata->addrlen);
+               if (mountdata->addr->sa_family == AF_UNSPEC)
+                       continue;
+               nfs_set_port(mountdata->addr, NFS_PORT);
+
+               strncpy(page2, buf->data, page2len);
+               page2[page2len] = '\0';
+               mountdata->hostname = page2;
+
+               snprintf(page, PAGE_SIZE, "%s:%s",
+                               mountdata->hostname,
+                               mountdata->mnt_path);
+
+               mnt = vfs_kern_mount(&nfs4_referral_fs_type, 0, page, mountdata);
+               if (!IS_ERR(mnt))
+                       break;
+       }
+       return mnt;
+}
 
 /**
  * nfs_follow_referral - set up mountpoint when hitting a referral on moved error
  * @mnt_parent - mountpoint of parent directory
  * @dentry - parent directory
- * @fspath - fs path returned in fs_locations
- * @mntpath - mount path to new server
- * @hostname - hostname of new server
- * @addr - host addr of new server
+ * @locations - array of NFSv4 server location information
  *
  */
 static struct vfsmount *nfs_follow_referral(const struct vfsmount *mnt_parent,
@@ -68,92 +158,46 @@ static struct vfsmount *nfs_follow_referral(const struct vfsmount *mnt_parent,
                .dentry = dentry,
                .authflavor = NFS_SB(mnt_parent->mnt_sb)->client->cl_auth->au_flavor,
        };
-       char *page, *page2;
-       char *path, *fs_path;
-       char *devname;
-       int loc, s;
+       char *page = NULL, *page2 = NULL;
+       int loc, error;
 
        if (locations == NULL || locations->nlocations <= 0)
                goto out;
 
-       dprintk("%s: referral at %s/%s\n", __FUNCTION__,
+       dprintk("%s: referral at %s/%s\n", __func__,
                dentry->d_parent->d_name.name, dentry->d_name.name);
 
-       /* Ensure fs path is a prefix of current dentry path */
        page = (char *) __get_free_page(GFP_USER);
-       if (page == NULL)
+       if (!page)
                goto out;
+
        page2 = (char *) __get_free_page(GFP_USER);
-       if (page2 == NULL)
+       if (!page2)
                goto out;
 
-       path = nfs4_path(dentry, page, PAGE_SIZE);
-       if (IS_ERR(path))
-               goto out_free;
-
-       fs_path = nfs4_pathname_string(&locations->fs_path, page2, PAGE_SIZE);
-       if (IS_ERR(fs_path))
-               goto out_free;
-
-       if (strncmp(path, fs_path, strlen(fs_path)) != 0) {
-               dprintk("%s: path %s does not begin with fsroot %s\n", __FUNCTION__, path, fs_path);
-               goto out_free;
-       }
-
-       devname = nfs_devname(mnt_parent, dentry, page, PAGE_SIZE);
-       if (IS_ERR(devname)) {
-               mnt = (struct vfsmount *)devname;
-               goto out_free;
+       /* Ensure fs path is a prefix of current dentry path */
+       error = nfs4_validate_fspath(mnt_parent, dentry, locations, page, page2);
+       if (error < 0) {
+               mnt = ERR_PTR(error);
+               goto out;
        }
 
-       loc = 0;
-       while (loc < locations->nlocations && IS_ERR(mnt)) {
+       for (loc = 0; loc < locations->nlocations; loc++) {
                const struct nfs4_fs_location *location = &locations->locations[loc];
-               char *mnt_path;
 
                if (location == NULL || location->nservers <= 0 ||
-                   location->rootpath.ncomponents == 0) {
-                       loc++;
+                   location->rootpath.ncomponents == 0)
                        continue;
-               }
 
-               mnt_path = nfs4_pathname_string(&location->rootpath, page2, PAGE_SIZE);
-               if (IS_ERR(mnt_path)) {
-                       loc++;
-                       continue;
-               }
-               mountdata.mnt_path = mnt_path;
-
-               s = 0;
-               while (s < location->nservers) {
-                       struct sockaddr_in addr = {};
-
-                       if (location->servers[s].len <= 0 ||
-                           valid_ipaddr4(location->servers[s].data) < 0) {
-                               s++;
-                               continue;
-                       }
-
-                       mountdata.hostname = location->servers[s].data;
-                       addr.sin_addr.s_addr = in_aton(mountdata.hostname);
-                       addr.sin_family = AF_INET;
-                       addr.sin_port = htons(NFS_PORT);
-                       mountdata.addr = &addr;
-
-                       mnt = vfs_kern_mount(&nfs_referral_nfs4_fs_type, 0, devname, &mountdata);
-                       if (!IS_ERR(mnt)) {
-                               break;
-                       }
-                       s++;
-               }
-               loc++;
+               mnt = try_location(&mountdata, page, page2, location);
+               if (!IS_ERR(mnt))
+                       break;
        }
 
-out_free:
-       free_page((unsigned long)page);
-       free_page((unsigned long)page2);
 out:
-       dprintk("%s: done\n", __FUNCTION__);
+       free_page((unsigned long) page);
+       free_page((unsigned long) page2);
+       dprintk("%s: done\n", __func__);
        return mnt;
 }
 
@@ -165,14 +209,14 @@ out:
  */
 struct vfsmount *nfs_do_refmount(const struct vfsmount *mnt_parent, struct dentry *dentry)
 {
-       struct vfsmount *mnt = ERR_PTR(-ENOENT);
+       struct vfsmount *mnt = ERR_PTR(-ENOMEM);
        struct dentry *parent;
        struct nfs4_fs_locations *fs_locations = NULL;
        struct page *page;
        int err;
 
        /* BUG_ON(IS_ROOT(dentry)); */
-       dprintk("%s: enter\n", __FUNCTION__);
+       dprintk("%s: enter\n", __func__);
 
        page = alloc_page(GFP_KERNEL);
        if (page == NULL)
@@ -183,11 +227,16 @@ struct vfsmount *nfs_do_refmount(const struct vfsmount *mnt_parent, struct dentr
                goto out_free;
 
        /* Get locations */
+       mnt = ERR_PTR(-ENOENT);
+
        parent = dget_parent(dentry);
-       dprintk("%s: getting locations for %s/%s\n", __FUNCTION__, parent->d_name.name, dentry->d_name.name);
-       err = nfs4_proc_fs_locations(parent->d_inode, dentry, fs_locations, page);
+       dprintk("%s: getting locations for %s/%s\n",
+               __func__, parent->d_name.name, dentry->d_name.name);
+
+       err = nfs4_proc_fs_locations(parent->d_inode, &dentry->d_name, fs_locations, page);
        dput(parent);
-       if (err != 0 || fs_locations->nlocations <= 0 ||
+       if (err != 0 ||
+           fs_locations->nlocations <= 0 ||
            fs_locations->fs_path.ncomponents <= 0)
                goto out_free;
 
@@ -196,6 +245,6 @@ out_free:
        __free_page(page);
        kfree(fs_locations);
 out:
-       dprintk("%s: done\n", __FUNCTION__);
+       dprintk("%s: done\n", __func__);
        return mnt;
 }